Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: change #inter#face to #interface #1675

Closed
dougburks opened this issue Dec 11, 2019 · 3 comments
Closed

Setup: change #inter#face to #interface #1675

dougburks opened this issue Dec 11, 2019 · 3 comments
Assignees
Projects

Comments

@dougburks
Copy link
Contributor

@dougburks dougburks commented Dec 11, 2019

https://github.com/Security-Onion-Solutions/securityonion-setup/blob/master/bin/sosetup#L1478-L1489

sets this:

#inter#face=$INTERFACE

We should change that to:

#interface=$INTERFACE

so that folks can simply remove the comment mark at the beginning of the line.

I think that second comment mark may have been trying to avoid a match here:
https://github.com/Security-Onion-Solutions/securityonion-setup/blob/master/bin/sosetup#L1938-L1940

BRO_IFACE=$(grep "interface=" /opt/bro/etc/node.cfg | cut -d'=' -f2)

If that's all we were trying to avoid, we could simply change the grep to:

grep "^interface="

But we should probably double-check that there are no extra corner cases lurking somewhere.

@dougburks dougburks added this to To do in 16.04.6.4 via automation Dec 11, 2019
@dougburks dougburks self-assigned this Dec 23, 2019
@dougburks dougburks moved this from To do to In progress in 16.04.6.4 Dec 23, 2019
@dougburks

This comment has been minimized.

Copy link
Contributor Author

@dougburks dougburks commented Dec 24, 2019

@dougburks dougburks moved this from In progress to In Testing in 16.04.6.4 Jan 4, 2020
@weslambert

This comment has been minimized.

Copy link
Collaborator

@weslambert weslambert commented Jan 17, 2020

Confirmed setup now changes the format 👍

@weslambert weslambert moved this from In Testing to Tested in 16.04.6.4 Jan 17, 2020
@dougburks

This comment has been minimized.

@dougburks dougburks closed this Feb 5, 2020
16.04.6.4 automation moved this from Tested to Done Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
16.04.6.4
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.