Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSM: broctl and zeekctl need to check if parameters were passed #1713

Closed
dougburks opened this issue Feb 1, 2020 · 3 comments
Closed

NSM: broctl and zeekctl need to check if parameters were passed #1713

dougburks opened this issue Feb 1, 2020 · 3 comments
Assignees
Projects

Comments

@dougburks
Copy link
Contributor

@dougburks dougburks commented Feb 1, 2020

/usr/sbin/broctl and /usr/sbin/zeekctl are user convenience shims that call the real /opt/bro/bin/zeekctl. We recently added some greps to these shims to clean up some of the unnecessary warnings. However, grep is preventing the user from running the zeekctl shell interactively. The easiest fix is to check for parameters and only pipe into grep if parameters were passed.

@dougburks dougburks self-assigned this Feb 1, 2020
@dougburks dougburks added this to To do in 16.04.6.4 via automation Feb 1, 2020
dougburks added a commit to Security-Onion-Solutions/securityonion-nsmnow-admin-scripts that referenced this issue Feb 1, 2020
@dougburks dougburks moved this from To do to In progress in 16.04.6.4 Feb 1, 2020
@dougburks dougburks moved this from In progress to In Testing in 16.04.6.4 Feb 1, 2020
@dougburks

This comment has been minimized.

Copy link
Contributor Author

@dougburks dougburks commented Feb 3, 2020

After installing securityonion-nsmnow-admin-scripts - 20120724-0ubuntu0securityonion225, please test as follows:

  • verify that sudo broctl and sudo zeekctl both start the zeekctl shell and you're able to interact with it

  • verify that you can pass parameters like sudo zeekctl status and get just the status information without any unnecessary warnings

@defensivedepth

This comment has been minimized.

Copy link
Collaborator

@defensivedepth defensivedepth commented Feb 5, 2020

Looks good to me!

@dougburks

This comment has been minimized.

@dougburks dougburks closed this Feb 5, 2020
16.04.6.4 automation moved this from In Testing to Done Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
16.04.6.4
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.