Make createLanguageEngagement dropdown to be more informative #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the options on that comparator if it is provided, and provide a way to pass in a renderOption using getOptionLabel if the renderOption is not provided
…bheader, define a comparator for comparing options to each other based on whether it's an id in the engagedIds list, disable an option if it's in the engagedIds list, provide each option as a listItem including the ethcode and rod
…uageEngagement is going to use it)
|
|
elisabeth-sorrell
changed the title
…d ethcode of the language selected.
|
|
|
This lived to the end of its lifetime and died |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1112
┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466496941