-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments functionality #1166
Comments functionality #1166
Conversation
523c263
to
6fb3806
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress!
UI Comments
The title/close button need some work. The icon is stretched instead of giving it its proper space.
The title style seems a little weird too... maybe an h3
would be better.
I think the title could be dropped here and the placeholder changed to "Write a comment..."
These shadows look weird. Each thread should be at the same "0" elevation in the list, so just like a line border appearance. It was just the thread replies that were supposed to look like a "sub-drawer" that was "further below" the list of threads.
This doesn't seem the best. Perhaps we can just have a reply button in the bottom right of the comment thread instead?
- "Hide Replies" doesn't look that good. What if we did an expand icon in the bottom right, below the context button?
Maybe a "Reply" button could sit to the left of that? - I'm not happy with the indentation of the replies. I think that's valuable real estate to be consuming. I think if we can make the "sub drawer" appear "under" more that would be better. It's also two competing designs trying to communicate the same thing: shadows and indentation. If the shadows are not enough, maybe a different subtle background shade could help?
src/scenes/Root/CommentsBar/CommentItemMenu/CommentMenuItem.tsx
Outdated
Show resolved
Hide resolved
src/scenes/Root/CommentsBar/CommentThread/CommentThreadAccordion.tsx
Outdated
Show resolved
Hide resolved
@CarsonF , we should probably just close this as it has been stale for a while and brings no value. |
This lived to the end of its lifetime and died |
Created the comments feature to enable the use of Rich text using the EditorJs library.
Currently the only Commentable we have is the Project object and we're possibly looking into making other object commentable as well. Because this PR is not as much focused on the Comments feature but more on the Rich text, we put aside some API work which was not critical to the Rich text feature.
┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466486753