Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiplatform sbom and vulnscan #160

Merged
merged 18 commits into from
Aug 21, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Aug 18, 2023

Contributor Comments

This fixes multiplatform SBOM generation and vuln scanning. Little tricky and some workarounds due to:

Manual Testing

To test this I was running task -v clean; for platform in all linux/arm64 linux/amd64; do PLATFORM=$platform task -v build; PLATFORM=$platform task -v sbom vulnscan; done and you should see:

  • Success across the board; no failures with "all" or the specific platform build, sbom, or vulnscan runs
  • SBOMs and vuln scan results locally that are not empty and are properly formatted. The size of the arm64 and amd64 images should be different.
  • You should see tar files in your local environment for the platform that you aren't on - so that would be the multiplatform build (arm and amd) and the arm (if you are on amd) or the amd (if you are on arm). If you are on arm, the arm build (or amd with amd) should be loaded into your docker daemon; see that with docker image ls | head -10

There may be some other, better and more creative ways to test.

Pull Request Checklist

Thank you for submitting a contribution to the goat!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

Task/Taskfile.yml Outdated Show resolved Hide resolved
Task/Taskfile.yml Outdated Show resolved Hide resolved
@JonZeolla JonZeolla marked this pull request as draft August 18, 2023 19:23
.gitignore Show resolved Hide resolved
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChiefHolland ChiefHolland merged commit 2cb2176 into main Aug 21, 2023
3 checks passed
@ChiefHolland ChiefHolland deleted the support-multiplatform-sbom-generation branch August 21, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants