Support timed belief db mixin #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By indexing timed beliefs by their event start and their sensor id, queries can become much faster.
nhoening
requested changes
Mar 31, 2021
| @@ -136,3 +136,6 @@ def test_custom_source_and_beliefs_with_mixin(db): | |||
|
|
|||
| assert "my_belief_source" in db.tables.keys() | |||
| assert "my_timed_belief" in db.tables.keys() | |||
|
|
|||
| bdf = JoyfulBeliefInCustomTable.query(session, sensor) | |||
There was a problem hiding this comment.
Is this supposed to be query_all? If so, why does this assertion work? Is bdf maybe an sqlachemy.Query object instead of a BeliefsDataFrame?
There was a problem hiding this comment.
I used query on purpose, to have a test that triggers the corresponding FutureWarning. I've been following this strategy for all deprecations, for two reasons:
- The test suite will show FutureWarnings for upcoming deprecations, which keeps reminding developers to actually deprecate at some point.
- The developer that implements the actual deprecation will break the test, and is therefore made aware of the fact that dependent code may break (and hopefully, reflect on whether enough time has passed since the deprecation was announced).
I'm glad you noticed this, because giving it some more thought I can come up with a few things to improve this strategy:
- Add a todo to the assert statement to amend the upcoming deprecation.
- Note the version at which the deprecation was announced.
nhoening
reviewed
Apr 1, 2021
nhoening
reviewed
Apr 1, 2021
|
Does my last commit resolve you last question? |
nhoening
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the TimedBeliefDBMixin, including: