Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linearity docs nb first commit #180

Merged
merged 7 commits into from Feb 20, 2020
Merged

Conversation

gipster
Copy link
Contributor

@gipster gipster commented Feb 13, 2020

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #180 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   86.75%   86.78%   +0.02%     
==========================================
  Files          36       36              
  Lines        3549     3549              
==========================================
+ Hits         3079     3080       +1     
+ Misses        470      469       -1
Impacted Files Coverage Δ
alibi/explainers/cfproto.py 75.28% <0%> (+0.16%) ⬆️

Copy link
Member

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add link to doc/source/index.rst
  • The documentation is not rendering properly, please check
  • I would remove the arrows on top of vectors as this notation is not used in ML
  • Remove last trailing empty cell

@jklaise jklaise merged commit 994871f into SeldonIO:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants