Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELDON_LOG_LEVEL parameter in Python Wrapper #708

Closed
axsaucedo opened this issue Jul 19, 2019 · 1 comment · Fixed by #743
Closed

Add SELDON_LOG_LEVEL parameter in Python Wrapper #708

axsaucedo opened this issue Jul 19, 2019 · 1 comment · Fixed by #743
Assignees
Projects

Comments

@axsaucedo
Copy link
Contributor

Currently the SELDON_LOG_LEVEL environment variable is being used only in the seldon-engine/.../application.properties file for the seldon engine config file. The functionality is present in the microservice.py CLI so it would just be a matter of adding it in the S2I Python Wrapper run file in order to allow for the Log level to be changed through the seldon config file.

It would also be good to include a mention in the docs about this when this is introduced as it only seems to be documented when GS answered the questions in #560

@ukclivecox ukclivecox added this to To do in 0.4.0 via automation Jul 25, 2019
@axsaucedo
Copy link
Contributor Author

This requires an extra extension to update the operator such that when this is set in the Seldon Definition, it's affected across all the containers across the graph.

@axsaucedo axsaucedo moved this from To do to In progress in 0.4.0 Aug 1, 2019
@axsaucedo axsaucedo moved this from In progress to Done in 0.4.0 Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.4.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant