Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrapper compatibility notes #1616

Merged

Conversation

RafalSkolasinski
Copy link
Member

closes #1564 because it adds note on compatibility for Seldon Core 1.0.x

@seldondev
Copy link
Collaborator

Thu Mar 26 17:54:58 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1616/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1616 --build=2

@seldondev
Copy link
Collaborator

Thu Mar 26 17:55:03 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1616/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1616 --build=1

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 24cad06 into SeldonIO:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document compatbility of wrapper versions with seldon engine versions
3 participants