Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notebook server_examples to not fail on MLFlow server #2050

Merged

Conversation

RafalSkolasinski
Copy link
Member

@RafalSkolasinski RafalSkolasinski commented Jun 30, 2020

It seems that fix introduced in baa3f14 didn't apply to notebook test as the notebook is overwriting elasticnet_wine.yaml manifest.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@RafalSkolasinski
Copy link
Member Author

/test notebooks

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rafalskolasinski

If they are not already assigned, you can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jun 30 12:44:47 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2050/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2050 --build=2

@seldondev
Copy link
Collaborator

Tue Jun 30 12:44:48 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2050/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2050 --build=3

@seldondev
Copy link
Collaborator

Tue Jun 30 12:44:57 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2050/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2050 --build=1

@ukclivecox ukclivecox added this to In progress in 1.2.1 via automation Jun 30, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Jun 30, 2020
@ukclivecox ukclivecox merged commit dae2cf2 into SeldonIO:master Jun 30, 2020
1.2.1 automation moved this from In progress to Done Jun 30, 2020
@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 56c5844 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Member Author

Just to comment that modified notebook passed the test. Failure reported is in TestNotebooks.test_metadata that was not modified by this PR. Probably flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.2.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants