Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed spam examples #2096

Merged
merged 2 commits into from Jul 9, 2020

Conversation

axsaucedo
Copy link
Contributor

Fixes #1938

Removing spam classifier examples as there has been multiple bugs reported, we'll be looking to add new examples to document combiners/transformers better instead.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@axsaucedo axsaucedo requested a review from ukclivecox July 9, 2020 07:34
@seldondev
Copy link
Collaborator

Thu Jul 9 07:35:07 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2096/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2096 --build=2

@seldondev
Copy link
Collaborator

Thu Jul 9 07:35:24 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2096/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2096 --build=1

@seldondev
Copy link
Collaborator

Thu Jul 9 07:41:55 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2096/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2096 --build=3

@seldondev
Copy link
Collaborator

Thu Jul 9 07:42:07 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2096/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2096 --build=4

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 25ab8ad into SeldonIO:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Empty Json Parameter in data" for model components in Spam Classifier Example
3 participants