Expose more boolean Flask Configurations via FLASK_ prefix

[ericandrewmeadows]

What this PR does / why we need it:
When failures occur, it is useful to expose where Exceptions are occurring. By default, you just get a 500 HTTP Status code, and no details on the line of the failure.

Which issue(s) this PR fixes:

Fixes #
No issue filed

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Exposes the ability to set the PROPAGATE_EXCEPTIONS for the Flask Python Wrapper, allowing for better debugging when interacting with models that use additional functions in their class declaration.

[seldondev]

Hi @ericandrewmeadows. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[ericandrewmeadows]

Minor request - can Prettier be used for formatting Markdown files?

[adriangonz]

/cc @RafalSkolasinski @adriangonz

[adriangonz]

Hey @ericandrewmeadows,

Thanks a lot for your contribution! I think this is definitely a great start and something needed. I've added a few minor comments, but I like the overall intention of the PR.

Regarding prettier, it would be good to raise it in today's community call to gather everyone else's thoughts.

[adriangonz]

Since we are iterating over a list of allowed variables, would it be possible to iterate over those instead of os.environ.items()?

[ericandrewmeadows]

Yeah - that's fair.

[ericandrewmeadows]

The original design here was to allow users to set any flask configs they would like, and if they tried to set an unsupported one, it would be called out in the logs.

[adriangonz]

/approve

Thanks for adding those changes in @ericandrewmeadows! I think this looks good to go now.

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[axsaucedo]

/ok-to-test

[seldondev]

Fri Sep 4 12:20:06 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2280/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2280 --build=2

[seldondev]

Fri Sep 4 12:20:28 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2280/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2280 --build=1

[seldondev]

Fri Sep 4 12:40:41 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2280/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2280 --build=3

[seldondev]

Fri Sep 4 12:40:49 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2280/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2280 --build=4