New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose more boolean Flask Configurations via FLASK_
prefix
#2280
Expose more boolean Flask Configurations via FLASK_
prefix
#2280
Conversation
Hi @ericandrewmeadows. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
…ericandrewmeadows/seldon-core into eric/propagate_flask_exceptions_enabled
FLASK_
prefix
Minor request - can Prettier be used for formatting Markdown files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericandrewmeadows,
Thanks a lot for your contribution! I think this is definitely a great start and something needed. I've added a few minor comments, but I like the overall intention of the PR.
Regarding prettier
, it would be good to raise it in today's community call to gather everyone else's thoughts.
python/seldon_core/wrapper.py
Outdated
"USE_X_SENDFILE", | ||
] | ||
|
||
for env_var, value in os.environ.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are iterating over a list of allowed variables, would it be possible to iterate over those instead of os.environ.items()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - that's fair.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original design here was to allow users to set any flask configs they would like, and if they tried to set an unsupported one, it would be called out in the logs.
/approve Thanks for adding those changes in @ericandrewmeadows! I think this looks good to go now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Fri Sep 4 12:20:06 UTC 2020 impatient try |
Fri Sep 4 12:20:28 UTC 2020 impatient try |
Fri Sep 4 12:40:41 UTC 2020 impatient try |
Fri Sep 4 12:40:49 UTC 2020 impatient try |
What this PR does / why we need it:
When failures occur, it is useful to expose where Exceptions are occurring. By default, you just get a
500
HTTP Status code, and no details on the line of the failure.Which issue(s) this PR fixes:
Fixes #
No issue filed
Special notes for your reviewer:
Does this PR introduce a user-facing change?: