Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use copy of operator instead of symlink to keep docker build context local #2335

Merged

Conversation

RafalSkolasinski
Copy link
Member

What this PR does / why we need it:

Uses (automated) copy of operator into executor/_operator to avoid symlinks and keep Docker build context local to executor folder

Which issue(s) this PR fixes:

Closes #2186

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev
Copy link
Collaborator

Thu Aug 27 13:02:26 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=2

@seldondev
Copy link
Collaborator

Thu Aug 27 13:03:42 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=3

@seldondev
Copy link
Collaborator

Thu Aug 27 13:04:03 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=1

@RafalSkolasinski
Copy link
Member Author

/retest

@seldondev
Copy link
Collaborator

Thu Aug 27 15:56:26 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=4

@RafalSkolasinski
Copy link
Member Author

/retest

@seldondev
Copy link
Collaborator

Thu Aug 27 18:11:11 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=5

@RafalSkolasinski
Copy link
Member Author

different tests seems to fail in each run
/retest

@RafalSkolasinski
Copy link
Member Author

/retest

@seldondev
Copy link
Collaborator

Thu Aug 27 20:43:44 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=6

@axsaucedo
Copy link
Contributor

/approve

@RafalSkolasinski
Copy link
Member Author

/retest

@seldondev
Copy link
Collaborator

Fri Aug 28 09:37:41 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=7

@RafalSkolasinski
Copy link
Member Author

failing test should be fixed by #2341

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Sep 1 08:40:50 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=8

@seldondev
Copy link
Collaborator

Tue Sep 1 08:40:54 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=10

@seldondev
Copy link
Collaborator

Tue Sep 1 08:40:55 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=9

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev
Copy link
Collaborator

Tue Sep 1 09:24:46 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=11

@seldondev
Copy link
Collaborator

Tue Sep 1 09:25:02 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=12

@seldondev
Copy link
Collaborator

Tue Sep 1 09:25:21 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=13

@seldondev
Copy link
Collaborator

Tue Sep 1 11:23:57 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=14

@seldondev
Copy link
Collaborator

Tue Sep 1 11:24:01 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2335/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2335 --build=15

@seldondev seldondev merged commit 16c48cf into SeldonIO:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change docker build context for executor to speed up build process
3 participants