Upgrade dependencies version in Base image #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
diemol
reviewed
Dec 12, 2023
| LABEL authors="Selenium <selenium-developers@googlegroups.com>" | ||
|
|
||
| # Arguments to define the version of dependencies to download | ||
| ARG VERSION | ||
| ARG RELEASE=selenium-${VERSION} | ||
| ARG OPENTELEMETRY_VERSION=1.31.0 | ||
| ARG GRPC_VERSION=1.59.0 | ||
| ARG GRPC_VERSION=1.60.0 |
There was a problem hiding this comment.
I am not sure why this was in 1.59.0, but this should be aligned with the upstream repo https://github.com/SeleniumHQ/selenium/blob/selenium-4.16.1-java/java/maven_deps.bzl#L32
There was a problem hiding this comment.
Yes, let me take note of this one and revert the same version upstream in the next deploy.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Upgrade dependencies version in Base
Motivation and Context
Based OS from
ubuntu:jammy-20231004toubuntu:jammy-20231128grpc-netty (is used for tracing enabled) from
1.59.0to1.60.0Types of changes
Checklist