Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python sample for firefox #274

Closed
wants to merge 5 commits into from

Conversation

@adithyab94
Copy link
Contributor

commented Aug 1, 2019

Added python sample for setting FireFoxOptions and Setting a custom profile for FireFox

Update python sample for firefox
Added python sample for setting FireFoxOptions and Setting a custom profile for FireFox
@diemol
Copy link
Member

left a comment

@adithyab94 could you please address the comments so we can go ahead and merge this PR? Thanks!

diemol and others added some commits Aug 2, 2019

Update driver_specific_capabilities.md
driver_specific_capabilities.md to fix the code review comments
@diemol
Copy link
Member

left a comment

@adithyab94 Could you please update your fork and solve the merge conflicts please?

adithyab94 added some commits Aug 6, 2019

update driver_specific_capabilities.en.md
update driver_specific_capabilities.en.md to commit resolve conflicts
@adithyab94

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Updated the above changes in new pull request - #291

@adithyab94

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Updated the above changes in new pull request - #291

This pull request was raised from browser so it become quite messy. So created a new pull request-#291

Sorry for inconvenience

@diemol

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Replaced by #291

@diemol diemol closed this Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.