From 5040a5aa4ed1e6fe807fbeb1e5957b6e0513aa5c Mon Sep 17 00:00:00 2001 From: titusfortner Date: Mon, 22 Jan 2024 12:51:59 -0600 Subject: [PATCH] [rb] checking wrong public method for full page screenshots --- rb/lib/selenium/webdriver/common/takes_screenshot.rb | 2 +- .../integration/selenium/webdriver/takes_screenshot_spec.rb | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/rb/lib/selenium/webdriver/common/takes_screenshot.rb b/rb/lib/selenium/webdriver/common/takes_screenshot.rb index 94ec6e365c5d1..965445ac26a2c 100644 --- a/rb/lib/selenium/webdriver/common/takes_screenshot.rb +++ b/rb/lib/selenium/webdriver/common/takes_screenshot.rb @@ -49,7 +49,7 @@ def save_screenshot(png_path, full_page: false) # @api public def screenshot_as(format, full_page: false) - if full_page && !respond_to?(:full_page) + if full_page && !respond_to?(:save_full_page_screenshot) raise Error::UnsupportedOperationError, "Full Page Screenshots are not supported for #{inspect}" end diff --git a/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb b/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb index 884cde1440b91..3cbc87ac970d2 100644 --- a/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb +++ b/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb @@ -110,7 +110,8 @@ def save_screenshot_and_assert(source, path) expect(height).to be > viewport_height end - it 'does not take full page screenshot', except: {browser: :firefox} do + it 'does not take full page screenshot', only: {browser: %i[chrome edge safari safari_preview], + reason: 'these browsers do not implement this feature'} do expect { driver.save_screenshot path, full_page: true }.to raise_exception(Error::UnsupportedOperationError, /Full Page Screenshots are not supported/)