From 8688ad2d0de251f28fbebf500e6e6527bd434f47 Mon Sep 17 00:00:00 2001 From: Alex Rodionov Date: Wed, 1 May 2024 20:54:09 -0700 Subject: [PATCH] [rb] Fix Chromium tests on Windows Apparently no-sandbox would keep zombie Chromium processes and would starve the resources. See https://github.com/SeleniumHQ/selenium/issues/5600. --- .github/workflows/ci-ruby.yml | 5 ----- .../selenium/webdriver/spec_support/test_environment.rb | 2 -- 2 files changed, 7 deletions(-) diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index deb56b656f4c0..653034f947f45 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -87,11 +87,6 @@ jobs: os: ubuntu - browser: safari os: windows - # TODO: Investigate why they are timing out - - browser: chrome - os: windows - - browser: edge - os: windows with: name: Local Tests (${{ matrix.browser }}, ${{ matrix.os }}) browser: ${{ matrix.browser }} diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb index 49c29177b0d1b..4c0bbe271fa22 100644 --- a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb +++ b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb @@ -243,7 +243,6 @@ def safari_preview_driver(**opts) def chrome_options(args: [], **opts) opts[:binary] ||= ENV['CHROME_BINARY'] if ENV.key?('CHROME_BINARY') args << '--headless=chrome' if ENV['HEADLESS'] - args << '--no-sandbox' args << '--disable-gpu' WebDriver::Options.chrome(browser_version: 'stable', args: args, **opts) end @@ -251,7 +250,6 @@ def chrome_options(args: [], **opts) def edge_options(args: [], **opts) opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY') args << '--headless=chrome' if ENV['HEADLESS'] - args << '--no-sandbox' args << '--disable-gpu' WebDriver::Options.edge(browser_version: 'stable', args: args, **opts) end