From e87363fcbffba927b2bebdca3b30ca244dfe8c37 Mon Sep 17 00:00:00 2001 From: Jason Juang Date: Thu, 11 Aug 2016 19:38:45 -0700 Subject: [PATCH] Fix W3C check in WebElement. The driver was changed in cefa1bfa8578211c84336766fbe2362f645d47ca to look at the 'status' field, rather than 'specificationLevel', but 941ddb9f1414a9ac5d8596cc6287b647ce295c96 (which predates it, but was merged later) was doing it the old way. This also avoids changing the constructor signature. --- py/selenium/webdriver/remote/webdriver.py | 2 +- py/selenium/webdriver/remote/webelement.py | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/py/selenium/webdriver/remote/webdriver.py b/py/selenium/webdriver/remote/webdriver.py index e2144c8188bbf..4ff6ba32d1635 100644 --- a/py/selenium/webdriver/remote/webdriver.py +++ b/py/selenium/webdriver/remote/webdriver.py @@ -198,7 +198,7 @@ def create_web_element(self, element_id): """ Creates a web element with the specified element_id. """ - return WebElement(self, element_id, capabilities=self.capabilities) + return WebElement(self, element_id, w3c=self.w3c) def _unwrap_value(self, value): if isinstance(value, dict) and ('ELEMENT' in value or 'element-6066-11e4-a52e-4f735466cecf' in value): diff --git a/py/selenium/webdriver/remote/webelement.py b/py/selenium/webdriver/remote/webelement.py index bd8dcb325084d..b44a3d3ba1b05 100644 --- a/py/selenium/webdriver/remote/webelement.py +++ b/py/selenium/webdriver/remote/webelement.py @@ -53,11 +53,10 @@ class WebElement(object): 'readonly', 'allowfullscreen', 'selected', 'formnovalidate', 'multiple', 'autofocus', 'open', 'loop', 'autoplay'] - def __init__(self, parent, id_, capabilities): + def __init__(self, parent, id_, w3c=False): self._parent = parent self._id = id_ - self.capabilities = capabilities - self._w3c = "specificationLevel" in self.capabilities + self._w3c = w3c def __repr__(self): return '<{0.__module__}.{0.__name__} (session="{1}", element="{2}")>'.format(