From f09642274e9dc2f9807da0addcc7eee93efee340 Mon Sep 17 00:00:00 2001
From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
Date: Sun, 7 Jul 2024 00:31:32 +0300
Subject: [PATCH] [dotnet] Return back protected synchronous Execute method in
WebDriver
---
dotnet/src/webdriver/Remote/HttpCommandExecutor.cs | 10 +++++-----
dotnet/src/webdriver/WebDriver.cs | 10 ++++++++--
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs b/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
index 9abd3d60d7ee3..f529b2aa0dbf1 100644
--- a/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
+++ b/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
@@ -153,10 +153,10 @@ public bool TryAddCommand(string commandName, CommandInfo info)
}
///
- /// Executes a command
+ /// Executes a command.
///
- /// The command you wish to execute
- /// A response from the browser
+ /// The command you wish to execute.
+ /// A response from the browser.
public virtual Response Execute(Command commandToExecute)
{
return Task.Run(() => this.ExecuteAsync(commandToExecute)).GetAwaiter().GetResult();
@@ -165,8 +165,8 @@ public virtual Response Execute(Command commandToExecute)
///
/// Executes a command as an asynchronous task.
///
- /// The command you wish to execute
- /// A task object representing the asynchronous operation
+ /// The command you wish to execute.
+ /// A task object representing the asynchronous operation.
public virtual async Task ExecuteAsync(Command commandToExecute)
{
if (commandToExecute == null)
diff --git a/dotnet/src/webdriver/WebDriver.cs b/dotnet/src/webdriver/WebDriver.cs
index d063e8f5905ea..33266516d2184 100644
--- a/dotnet/src/webdriver/WebDriver.cs
+++ b/dotnet/src/webdriver/WebDriver.cs
@@ -572,14 +572,20 @@ internal Task InternalExecuteAsync(string driverCommandToExecute,
return this.ExecuteAsync(driverCommandToExecute, parameters);
}
- internal Response Execute(string driverCommandToExecute,
+ ///
+ /// Executes a command with this driver.
+ ///
+ /// A value representing the command to execute.
+ /// A containing the names and values of the parameters of the command.
+ /// A containing information about the success or failure of the command and any data returned by the command.
+ protected virtual Response Execute(string driverCommandToExecute,
Dictionary parameters)
{
return Task.Run(() => this.ExecuteAsync(driverCommandToExecute, parameters)).GetAwaiter().GetResult();
}
///
- /// Executes a command with this driver .
+ /// Executes a command with this driver.
///
/// A value representing the command to execute.
/// A containing the names and values of the parameters of the command.