New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the test method name #1090

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@sri85
Contributor

sri85 commented Sep 30, 2015

Updated the test method name from test_we_can_launch_multiple_firefox_instances to test_we_can_launch_multiple_chrome_instances since it is a chrome test

Updated the test method name
Updated the test method name from `test_we_can_launch_multiple_firefox_instances` to `test_we_can_launch_multiple_chrome_instances` since it is a `chrome` test
@ddavison

This comment has been minimized.

Show comment
Hide comment
@ddavison

ddavison Oct 5, 2015

Member

have you signed the CLA?

Member

ddavison commented Oct 5, 2015

have you signed the CLA?

@ddavison

This comment has been minimized.

Show comment
Hide comment
@ddavison

ddavison Oct 5, 2015

Member

this is a very small change so i went ahead and merged it. (68dbd3e) Go ahead and still sign that CLA for me so any future merges you make, we won't have to worry about it :)

Member

ddavison commented Oct 5, 2015

this is a very small change so i went ahead and merged it. (68dbd3e) Go ahead and still sign that CLA for me so any future merges you make, we won't have to worry about it :)

@sri85

This comment has been minimized.

Show comment
Hide comment
@sri85

sri85 Oct 5, 2015

Contributor

Signed the CLA

Contributor

sri85 commented Oct 5, 2015

Signed the CLA

@sri85 sri85 closed this Oct 5, 2015

@sri85 sri85 reopened this Oct 5, 2015

@ddavison

This comment has been minimized.

Show comment
Hide comment
@ddavison

ddavison Oct 7, 2015

Member

excellent, thanks. this change has been merged in so we can close. (see above comment)

Member

ddavison commented Oct 7, 2015

excellent, thanks. this change has been merged in so we can close. (see above comment)

@ddavison ddavison closed this Oct 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment