Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd innerHTML attribute support to HtmlUnitDriver #1206
Conversation
Toilal
referenced this pull request
Oct 30, 2015
Merged
Add getTextContent method to display text content of an element #189
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
merged as a3b32a3 |
lukeis
closed this
Oct 30, 2015
ddavison
reviewed
Oct 30, 2015
| public void testShouldReturnInnerHtml() { | ||
| driver.get(pages.simpleTestPage); | ||
| String html = driver.findElement(By.id("wrappingtext")).getAttribute("innerHTML"); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ddavison
Oct 30, 2015
Member
this makes me wonder if we want to add a getProperty() in order to disambiguate properties from attributes..
ddavison
Oct 30, 2015
Member
this makes me wonder if we want to add a getProperty() in order to disambiguate properties from attributes..
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukeis
Oct 30, 2015
Member
ha... hahahahahah... you haven't been on this project very long, have you? :)
lukeis
Oct 30, 2015
Member
ha... hahahahahah... you haven't been on this project very long, have you? :)
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Toilal
Oct 30, 2015
Contributor
I wonder i'll never need to test any testContent attribute ! it seems there are some magic keys in WebDriver... Any reason the API was not extended to support methods like getHtml or getNodeText ?
Toilal
Oct 30, 2015
Contributor
I wonder i'll never need to test any testContent attribute ! it seems there are some magic keys in WebDriver... Any reason the API was not extended to support methods like getHtml or getNodeText ?
Toilal commentedOct 30, 2015
To be consistent with WebRemoteDriver, innerHTML attribute should retrieve innerHTML of the underlying DOM Node. (Same idea as #1205)