Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] fix http proxy configuration for chrome #13093

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

joromero
Copy link
Contributor

@joromero joromero commented Nov 3, 2023

Description

Fix an error that made selenium skip passing the http proxy params to chrome and chromium.

Motivation and Context

After investigating an error that started after bumping selenium, we realized the proxy configuration was being loaded incorrectly. After much research into it, we discovered the error was likely coming from how selenium passed the arguments. The error is the following:
Selenium::WebDriver::Error::NoSuchDriverError
Unable to obtain chromedriver using Selenium Manager; Unsuccessful command executed: ["/usr/local/bundle/gems/selenium-webdriver-4.14.0/bin/linux/selenium-manager", "--browser", "chrome", "--proxy", nil, "--output", "json"]; no implicit conversion of nil into String; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/driver_location

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023

CLA assistant check
All committers have signed the CLA.

@joromero joromero changed the title [rb] fix http proxy configuration [rb] fix http proxy configuration for chrome Nov 3, 2023
@titusfortner
Copy link
Member

Oh weird, I saw this earlier and would have sworn I fixed it. Thanks.

@diemol
Copy link
Member

diemol commented Nov 6, 2023

@titusfortner can this be merged?

@titusfortner titusfortner merged commit 194b060 into SeleniumHQ:trunk Nov 6, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants