From 55baa0af4823f70de26eb16b6b8b8a3aa25e6614 Mon Sep 17 00:00:00 2001 From: Scott Babcock Date: Fri, 24 May 2024 16:38:19 -0700 Subject: [PATCH] 14034: Eliminate assumption of mutable list argument --- .../openqa/selenium/manager/SeleniumManager.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/java/src/org/openqa/selenium/manager/SeleniumManager.java b/java/src/org/openqa/selenium/manager/SeleniumManager.java index 1723b7c769cfc..2c7acdbc9f1b5 100644 --- a/java/src/org/openqa/selenium/manager/SeleniumManager.java +++ b/java/src/org/openqa/selenium/manager/SeleniumManager.java @@ -28,6 +28,7 @@ import java.nio.file.Path; import java.nio.file.Paths; import java.time.Duration; +import java.util.ArrayList; import java.util.List; import java.util.Properties; import java.util.logging.Level; @@ -232,16 +233,18 @@ private synchronized Path getBinary() { * @return the locations of the assets from Selenium Manager execution */ public Result getBinaryPaths(List arguments) { - arguments.add("--language-binding"); - arguments.add("java"); - arguments.add("--output"); - arguments.add("json"); + List args = new ArrayList<>(arguments.size() + 5); + args.addAll(arguments); + args.add("--language-binding"); + args.add("java"); + args.add("--output"); + args.add("json"); if (getLogLevel().intValue() <= Level.FINE.intValue()) { - arguments.add("--debug"); + args.add("--debug"); } - return runCommand(getBinary(), arguments); + return runCommand(getBinary(), args); } private Level getLogLevel() {