From efc94aa7fa82ee1db4dad96484aa712a42f3e8a9 Mon Sep 17 00:00:00 2001 From: Samuel Montgomery-Blinn Date: Thu, 25 Jul 2024 11:19:12 -0400 Subject: [PATCH] Update remote_connection.py to allow proxy_url argument There are network topologies and configurations where a proxy for the remote connection makes sense, and you do not want to set a system-wide proxy using environment variables. --- py/selenium/webdriver/remote/remote_connection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py/selenium/webdriver/remote/remote_connection.py b/py/selenium/webdriver/remote/remote_connection.py index eab43d4693a6c..6f45ee94a6338 100644 --- a/py/selenium/webdriver/remote/remote_connection.py +++ b/py/selenium/webdriver/remote/remote_connection.py @@ -248,7 +248,7 @@ def _get_connection_manager(self): return urllib3.PoolManager(**pool_manager_init_args) - def __init__(self, remote_server_addr: str, keep_alive: bool = False, ignore_proxy: bool = False): + def __init__(self, remote_server_addr: str, keep_alive: bool = False, ignore_proxy: bool = False, proxy_url: str = None): self.keep_alive = keep_alive self._url = remote_server_addr @@ -271,7 +271,7 @@ def __init__(self, remote_server_addr: str, keep_alive: bool = False, ignore_pro ignore_proxy = True break - self._proxy_url = self._get_proxy_url() if not ignore_proxy else None + self._proxy_url = proxy_url if proxy_url else self._get_proxy_url() if not ignore_proxy else None if keep_alive: self._conn = self._get_connection_manager() self._commands = remote_commands