From f2998b13b531da525a04d2d94298098b3e704678 Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Fri, 1 Nov 2024 11:08:44 -0400 Subject: [PATCH 1/3] [py] Fixed Flaky Bidi Test --- py/test/selenium/webdriver/common/bidi_tests.py | 1 - 1 file changed, 1 deletion(-) diff --git a/py/test/selenium/webdriver/common/bidi_tests.py b/py/test/selenium/webdriver/common/bidi_tests.py index cfa34a55a6cae..c7c78bcc07fb3 100644 --- a/py/test/selenium/webdriver/common/bidi_tests.py +++ b/py/test/selenium/webdriver/common/bidi_tests.py @@ -76,7 +76,6 @@ async def test_collect_log_mutations(driver, pages): WebDriverWait(driver, 10).until( lambda d: d.find_element(By.ID, "revealed").value_of_css_property("display") != "none" ) - WebDriverWait(driver, 5).until(EC.visibility_of(driver.find_element(By.ID, "revealed"))) assert event["attribute_name"] == "style" assert event["current_value"] == "" From 82ab23d017f77a59e10bab43c0c640aa64aa1ce5 Mon Sep 17 00:00:00 2001 From: Simon Benzer <69980130+shbenzer@users.noreply.github.com> Date: Sat, 2 Nov 2024 09:51:16 -0400 Subject: [PATCH 2/3] linting --- py/test/selenium/webdriver/common/bidi_tests.py | 1 - 1 file changed, 1 deletion(-) diff --git a/py/test/selenium/webdriver/common/bidi_tests.py b/py/test/selenium/webdriver/common/bidi_tests.py index c7c78bcc07fb3..469b37342db8e 100644 --- a/py/test/selenium/webdriver/common/bidi_tests.py +++ b/py/test/selenium/webdriver/common/bidi_tests.py @@ -76,7 +76,6 @@ async def test_collect_log_mutations(driver, pages): WebDriverWait(driver, 10).until( lambda d: d.find_element(By.ID, "revealed").value_of_css_property("display") != "none" ) - assert event["attribute_name"] == "style" assert event["current_value"] == "" assert event["old_value"] == "display:none;" From 60fd0000d150aa919b406778f3be9e609426749a Mon Sep 17 00:00:00 2001 From: Simon Benzer <69980130+shbenzer@users.noreply.github.com> Date: Sat, 2 Nov 2024 09:54:07 -0400 Subject: [PATCH 3/3] removed unused import --- py/test/selenium/webdriver/common/bidi_tests.py | 1 - 1 file changed, 1 deletion(-) diff --git a/py/test/selenium/webdriver/common/bidi_tests.py b/py/test/selenium/webdriver/common/bidi_tests.py index 469b37342db8e..6872bc211f4ba 100644 --- a/py/test/selenium/webdriver/common/bidi_tests.py +++ b/py/test/selenium/webdriver/common/bidi_tests.py @@ -18,7 +18,6 @@ from selenium.webdriver.common.by import By from selenium.webdriver.common.log import Log -from selenium.webdriver.support import expected_conditions as EC from selenium.webdriver.support.ui import WebDriverWait