From 1f2b1e18d9e4eca1dc8eba50ce5327b5d7b40af9 Mon Sep 17 00:00:00 2001 From: Michael Render Date: Wed, 5 Feb 2025 14:33:34 -0500 Subject: [PATCH] [dotnet] Annotate nullability on Domains --- dotnet/src/webdriver/DevTools/DevToolsDomains.cs | 4 ++-- dotnet/src/webdriver/DevTools/v130/V130Domains.cs | 9 +++++++-- dotnet/src/webdriver/DevTools/v131/V131Domains.cs | 9 +++++++-- dotnet/src/webdriver/DevTools/v132/V132Domains.cs | 9 +++++++-- dotnet/src/webdriver/DevTools/v85/V85Domains.cs | 9 +++++++-- 5 files changed, 30 insertions(+), 10 deletions(-) diff --git a/dotnet/src/webdriver/DevTools/DevToolsDomains.cs b/dotnet/src/webdriver/DevTools/DevToolsDomains.cs index 4b8e688e1029b..bf2246bb0bffa 100644 --- a/dotnet/src/webdriver/DevTools/DevToolsDomains.cs +++ b/dotnet/src/webdriver/DevTools/DevToolsDomains.cs @@ -82,7 +82,7 @@ public abstract class DevToolsDomains /// Initializes the supplied DevTools session's domains for the specified browser version. /// /// The version of the DevTools Protocol to use. - /// The for which to initialiize the domains. + /// The for which to initialize the domains. /// The object containing the version-specific domains. /// If is negative. /// If the desired protocol version is not supported. @@ -95,7 +95,7 @@ public static DevToolsDomains InitializeDomains(int protocolVersion, DevToolsSes /// Initializes the supplied DevTools session's domains for the specified browser version within the specified number of versions. /// /// The version of the DevTools Protocol to use. - /// The for which to initialiize the domains. + /// The for which to initialize the domains. /// The range of versions within which to match the provided version number. Defaults to 5 versions. /// The object containing the version-specific domains. /// If is negative. diff --git a/dotnet/src/webdriver/DevTools/v130/V130Domains.cs b/dotnet/src/webdriver/DevTools/v130/V130Domains.cs index d75c8ac61de59..75e7bac035802 100644 --- a/dotnet/src/webdriver/DevTools/v130/V130Domains.cs +++ b/dotnet/src/webdriver/DevTools/v130/V130Domains.cs @@ -17,6 +17,10 @@ // under the License. // +using System; + +#nullable enable + namespace OpenQA.Selenium.DevTools.V130 { /// @@ -24,15 +28,16 @@ namespace OpenQA.Selenium.DevTools.V130 /// public class V130Domains : DevToolsDomains { - private DevToolsSessionDomains domains; + private readonly DevToolsSessionDomains domains; /// /// Initializes a new instance of the V130Domains class. /// /// The DevToolsSession to use with this set of domains. + /// If is . public V130Domains(DevToolsSession session) { - this.domains = new DevToolsSessionDomains(session); + this.domains = new DevToolsSessionDomains(session ?? throw new ArgumentNullException(nameof(session))); } /// diff --git a/dotnet/src/webdriver/DevTools/v131/V131Domains.cs b/dotnet/src/webdriver/DevTools/v131/V131Domains.cs index 66fd521bf9f09..d7be2850d038e 100644 --- a/dotnet/src/webdriver/DevTools/v131/V131Domains.cs +++ b/dotnet/src/webdriver/DevTools/v131/V131Domains.cs @@ -17,6 +17,10 @@ // under the License. // +using System; + +#nullable enable + namespace OpenQA.Selenium.DevTools.V131 { /// @@ -24,15 +28,16 @@ namespace OpenQA.Selenium.DevTools.V131 /// public class V131Domains : DevToolsDomains { - private DevToolsSessionDomains domains; + private readonly DevToolsSessionDomains domains; /// /// Initializes a new instance of the V131Domains class. /// /// The DevToolsSession to use with this set of domains. + /// If is . public V131Domains(DevToolsSession session) { - this.domains = new DevToolsSessionDomains(session); + this.domains = new DevToolsSessionDomains(session ?? throw new ArgumentNullException(nameof(session))); } /// diff --git a/dotnet/src/webdriver/DevTools/v132/V132Domains.cs b/dotnet/src/webdriver/DevTools/v132/V132Domains.cs index e213729809e8d..095893698d090 100644 --- a/dotnet/src/webdriver/DevTools/v132/V132Domains.cs +++ b/dotnet/src/webdriver/DevTools/v132/V132Domains.cs @@ -17,6 +17,10 @@ // under the License. // +using System; + +#nullable enable + namespace OpenQA.Selenium.DevTools.V132 { /// @@ -24,15 +28,16 @@ namespace OpenQA.Selenium.DevTools.V132 /// public class V132Domains : DevToolsDomains { - private DevToolsSessionDomains domains; + private readonly DevToolsSessionDomains domains; /// /// Initializes a new instance of the V132Domains class. /// /// The DevToolsSession to use with this set of domains. + /// If is . public V132Domains(DevToolsSession session) { - this.domains = new DevToolsSessionDomains(session); + this.domains = new DevToolsSessionDomains(session ?? throw new ArgumentNullException(nameof(session))); } /// diff --git a/dotnet/src/webdriver/DevTools/v85/V85Domains.cs b/dotnet/src/webdriver/DevTools/v85/V85Domains.cs index 885296bbeb556..4285f0262de52 100644 --- a/dotnet/src/webdriver/DevTools/v85/V85Domains.cs +++ b/dotnet/src/webdriver/DevTools/v85/V85Domains.cs @@ -17,6 +17,10 @@ // under the License. // +using System; + +#nullable enable + namespace OpenQA.Selenium.DevTools.V85 { /// @@ -24,15 +28,16 @@ namespace OpenQA.Selenium.DevTools.V85 /// public class V85Domains : DevToolsDomains { - private DevToolsSessionDomains domains; + private readonly DevToolsSessionDomains domains; /// /// Initializes a new instance of the V85Domains class. /// /// The DevToolsSession to use with this set of domains. + /// If is . public V85Domains(DevToolsSession session) { - this.domains = new DevToolsSessionDomains(session); + this.domains = new DevToolsSessionDomains(session ?? throw new ArgumentNullException(nameof(session))); } ///