From 5da07b11f786fbdcf81a2a511848763e82e0b678 Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Wed, 12 Mar 2025 16:24:52 +0530 Subject: [PATCH] use By class attributes instead of strings --- py/selenium/webdriver/remote/locator_converter.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/py/selenium/webdriver/remote/locator_converter.py b/py/selenium/webdriver/remote/locator_converter.py index b43da73ef47cd..e924d7fd6904f 100644 --- a/py/selenium/webdriver/remote/locator_converter.py +++ b/py/selenium/webdriver/remote/locator_converter.py @@ -14,15 +14,16 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +from selenium.webdriver.common.by import By class LocatorConverter: def convert(self, by, value): # Default conversion logic - if by == "id": - return "css selector", f'[id="{value}"]' - elif by == "class name": - return "css selector", f".{value}" - elif by == "name": - return "css selector", f'[name="{value}"]' + if by == By.ID: + return By.CSS_SELECTOR, f'[id="{value}"]' + elif by == By.CLASS_NAME: + return By.CSS_SELECTOR, f".{value}" + elif by == By.NAME: + return By.CSS_SELECTOR, f'[name="{value}"]' return by, value