From 2dddbad20ced4a45be9001a755d03d2ff49e0692 Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Sun, 23 Mar 2025 13:15:50 +0300 Subject: [PATCH] [dotnet] [bidi] Decouple WindowProxyProperties in Script module --- .../BiDi/Modules/Script/RemoteValue.cs | 4 +--- .../Modules/Script/WindowProxyProperties.cs | 22 +++++++++++++++++++ 2 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 dotnet/src/webdriver/BiDi/Modules/Script/WindowProxyProperties.cs diff --git a/dotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs b/dotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs index 2456348d38324..af483e2bfbaab 100644 --- a/dotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs +++ b/dotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs @@ -260,13 +260,11 @@ public record NodeRemoteValue : RemoteValue, ISharedReference public NodeProperties? Value { get; internal set; } } -public record WindowProxyRemoteValue(WindowProxyRemoteValue.Properties Value) : RemoteValue +public record WindowProxyRemoteValue(WindowProxyProperties Value) : RemoteValue { public Handle? Handle { get; set; } public InternalId? InternalId { get; set; } - - public record Properties(BrowsingContext.BrowsingContext Context); } public abstract record PrimitiveProtocolRemoteValue : RemoteValue; diff --git a/dotnet/src/webdriver/BiDi/Modules/Script/WindowProxyProperties.cs b/dotnet/src/webdriver/BiDi/Modules/Script/WindowProxyProperties.cs new file mode 100644 index 0000000000000..0219f50b039f2 --- /dev/null +++ b/dotnet/src/webdriver/BiDi/Modules/Script/WindowProxyProperties.cs @@ -0,0 +1,22 @@ +// +// Licensed to the Software Freedom Conservancy (SFC) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The SFC licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// + +namespace OpenQA.Selenium.BiDi.Modules.Script; + +public record WindowProxyProperties(BrowsingContext.BrowsingContext Context);