From 57502f230c4005996a915ef2cc787bcd9627e48a Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Mon, 19 May 2025 20:42:06 -0400 Subject: [PATCH] [py] Better error for downloads on local webdrivers --- py/selenium/webdriver/chromium/webdriver.py | 6 ++++++ py/selenium/webdriver/firefox/webdriver.py | 6 ++++++ py/selenium/webdriver/ie/webdriver.py | 6 ++++++ py/selenium/webdriver/safari/webdriver.py | 6 ++++++ py/selenium/webdriver/webkitgtk/webdriver.py | 6 ++++++ py/selenium/webdriver/wpewebkit/webdriver.py | 6 ++++++ 6 files changed, 36 insertions(+) diff --git a/py/selenium/webdriver/chromium/webdriver.py b/py/selenium/webdriver/chromium/webdriver.py index 5dd01e7677dfa..4dcf8d73e8fe0 100644 --- a/py/selenium/webdriver/chromium/webdriver.py +++ b/py/selenium/webdriver/chromium/webdriver.py @@ -222,3 +222,9 @@ def quit(self) -> None: pass finally: self.service.stop() + + def download_file(self, *args, **kwargs): + raise NotImplementedError + + def get_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/firefox/webdriver.py b/py/selenium/webdriver/firefox/webdriver.py index 643a330f306c2..4f4645cc0aae5 100644 --- a/py/selenium/webdriver/firefox/webdriver.py +++ b/py/selenium/webdriver/firefox/webdriver.py @@ -221,3 +221,9 @@ def get_full_page_screenshot_as_base64(self) -> str: driver.get_full_page_screenshot_as_base64() """ return self.execute("FULL_PAGE_SCREENSHOT")["value"] + + def download_file(self, *args, **kwargs): + raise NotImplementedError + + def get_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/ie/webdriver.py b/py/selenium/webdriver/ie/webdriver.py index 5eade176c1589..9aa28a64370a9 100644 --- a/py/selenium/webdriver/ie/webdriver.py +++ b/py/selenium/webdriver/ie/webdriver.py @@ -75,3 +75,9 @@ def quit(self) -> None: pass finally: self.service.stop() + + def download_file(self, *args, **kwargs): + raise NotImplementedError + + def get_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/safari/webdriver.py b/py/selenium/webdriver/safari/webdriver.py index 17cc615794a21..333fa50bb40ea 100644 --- a/py/selenium/webdriver/safari/webdriver.py +++ b/py/selenium/webdriver/safari/webdriver.py @@ -108,3 +108,9 @@ def get_permission(self, permission): def debug(self): self.execute("ATTACH_DEBUGGER") self.execute_script("debugger;") + + def download_file(self, *args, **kwargs): + raise NotImplementedError + + def get_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/webkitgtk/webdriver.py b/py/selenium/webdriver/webkitgtk/webdriver.py index ba1c03a18c945..dedf8df9d0db7 100644 --- a/py/selenium/webdriver/webkitgtk/webdriver.py +++ b/py/selenium/webdriver/webkitgtk/webdriver.py @@ -59,3 +59,9 @@ def quit(self): pass finally: self.service.stop() + + def download_file(self, *args, **kwargs): + raise NotImplementedError + + def get_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/wpewebkit/webdriver.py b/py/selenium/webdriver/wpewebkit/webdriver.py index 5019b512d3173..64e298cc475c5 100644 --- a/py/selenium/webdriver/wpewebkit/webdriver.py +++ b/py/selenium/webdriver/wpewebkit/webdriver.py @@ -59,3 +59,9 @@ def quit(self): pass finally: self.service.stop() + + def download_file(self, *args, **kwargs): + raise NotImplementedError + + def get_downloadable_files(self, *args, **kwargs): + raise NotImplementedError