From 98721aad829cc43b6dcf3b2813d2e6865354bee1 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Sun, 17 Aug 2025 21:55:58 +0200 Subject: [PATCH 1/3] [dotnet] Adding flag to enable SafariDriver logging. --- .../src/webdriver/Safari/SafariDriverService.cs | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/dotnet/src/webdriver/Safari/SafariDriverService.cs b/dotnet/src/webdriver/Safari/SafariDriverService.cs index 30f53d1336be7..e812a603b81a1 100644 --- a/dotnet/src/webdriver/Safari/SafariDriverService.cs +++ b/dotnet/src/webdriver/Safari/SafariDriverService.cs @@ -20,10 +20,7 @@ using OpenQA.Selenium.Internal; using System; using System.IO; -using System.Net; -using System.Net.Http; using System.Text; -using System.Threading.Tasks; namespace OpenQA.Selenium.Safari; @@ -34,6 +31,13 @@ public sealed class SafariDriverService : DriverService { private const string DefaultSafariDriverServiceExecutableName = "safaridriver"; + /// + /// Value to enable diagnose logging. + /// When set to true, the SafariDriver will be started with the --diagnose flag. + /// Logs will be written to ~/Library/Logs/com.apple.WebDriver/ + /// + public bool? Diagnose { get; set; } + /// /// Initializes a new instance of the class. /// @@ -59,6 +63,12 @@ protected override string CommandLineArguments get { StringBuilder argsBuilder = new StringBuilder(base.CommandLineArguments); + + if (this.Diagnose is true) + { + argsBuilder.Append(" --diagnose"); + } + return argsBuilder.ToString(); } } From 5f6e822de8a483d8f826fda9552ea2425dc365e6 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Mon, 18 Aug 2025 07:10:14 +0200 Subject: [PATCH 2/3] Update dotnet/src/webdriver/Safari/SafariDriverService.cs Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> --- dotnet/src/webdriver/Safari/SafariDriverService.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dotnet/src/webdriver/Safari/SafariDriverService.cs b/dotnet/src/webdriver/Safari/SafariDriverService.cs index e812a603b81a1..37095e3393df7 100644 --- a/dotnet/src/webdriver/Safari/SafariDriverService.cs +++ b/dotnet/src/webdriver/Safari/SafariDriverService.cs @@ -32,9 +32,9 @@ public sealed class SafariDriverService : DriverService private const string DefaultSafariDriverServiceExecutableName = "safaridriver"; /// - /// Value to enable diagnose logging. - /// When set to true, the SafariDriver will be started with the --diagnose flag. - /// Logs will be written to ~/Library/Logs/com.apple.WebDriver/ + /// Enable diagnose logging. + /// When set to , the SafariDriver will be started with the --diagnose flag. + /// Logs will be written to ~/Library/Logs/com.apple.WebDriver/. /// public bool? Diagnose { get; set; } From 0ff2a196f88baa6dbde0bb098b83ac16a09006c7 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Mon, 18 Aug 2025 07:10:22 +0200 Subject: [PATCH 3/3] Update dotnet/src/webdriver/Safari/SafariDriverService.cs Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> --- dotnet/src/webdriver/Safari/SafariDriverService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dotnet/src/webdriver/Safari/SafariDriverService.cs b/dotnet/src/webdriver/Safari/SafariDriverService.cs index 37095e3393df7..43f776648730e 100644 --- a/dotnet/src/webdriver/Safari/SafariDriverService.cs +++ b/dotnet/src/webdriver/Safari/SafariDriverService.cs @@ -36,7 +36,7 @@ public sealed class SafariDriverService : DriverService /// When set to , the SafariDriver will be started with the --diagnose flag. /// Logs will be written to ~/Library/Logs/com.apple.WebDriver/. /// - public bool? Diagnose { get; set; } + public bool? Diagnose { get; set; } /// /// Initializes a new instance of the class.