From 1828c9eca33e7051cc823f10b8bf40780d7a234b Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Fri, 3 Oct 2025 15:15:18 -0400 Subject: [PATCH 1/2] [py] Remove old test xfail markers from Travis CI --- py/test/selenium/webdriver/common/alerts_tests.py | 4 ---- py/test/selenium/webdriver/common/w3c_interaction_tests.py | 2 -- py/test/selenium/webdriver/common/window_tests.py | 7 ------- 3 files changed, 13 deletions(-) diff --git a/py/test/selenium/webdriver/common/alerts_tests.py b/py/test/selenium/webdriver/common/alerts_tests.py index 9143974cb9463..b42f270aa890e 100644 --- a/py/test/selenium/webdriver/common/alerts_tests.py +++ b/py/test/selenium/webdriver/common/alerts_tests.py @@ -157,8 +157,6 @@ def test_alert_should_not_allow_additional_commands_if_dimissed(driver, pages): alert.text -@pytest.mark.xfail_firefox(reason="Fails on travis") -@pytest.mark.xfail_remote(reason="Fails on travis") @pytest.mark.xfail_safari def test_should_allow_users_to_accept_an_alert_in_aframe(driver, pages): pages.load("alerts.html") @@ -171,8 +169,6 @@ def test_should_allow_users_to_accept_an_alert_in_aframe(driver, pages): assert "Testing Alerts" == driver.title -@pytest.mark.xfail_firefox(reason="Fails on travis") -@pytest.mark.xfail_remote(reason="Fails on travis") @pytest.mark.xfail_safari def test_should_allow_users_to_accept_an_alert_in_anested_frame(driver, pages): pages.load("alerts.html") diff --git a/py/test/selenium/webdriver/common/w3c_interaction_tests.py b/py/test/selenium/webdriver/common/w3c_interaction_tests.py index a234a0f93be36..bd1bb9f26c99a 100644 --- a/py/test/selenium/webdriver/common/w3c_interaction_tests.py +++ b/py/test/selenium/webdriver/common/w3c_interaction_tests.py @@ -146,8 +146,6 @@ def test_context_click(driver, pages): @pytest.mark.xfail_firefox @pytest.mark.xfail_safari -@pytest.mark.xfail_remote(reason="Fails on Travis") -@pytest.mark.xfail_chrome(reason="Fails on Travis") def test_double_click(driver, pages): """Copied from org.openqa.selenium.interactions.TestBasicMouseInterface.""" pages.load("javascriptPage.html") diff --git a/py/test/selenium/webdriver/common/window_tests.py b/py/test/selenium/webdriver/common/window_tests.py index 07f71c56cfd62..34f023d54a689 100644 --- a/py/test/selenium/webdriver/common/window_tests.py +++ b/py/test/selenium/webdriver/common/window_tests.py @@ -21,9 +21,6 @@ from selenium.webdriver.support.wait import WebDriverWait # @pytest.mark.xfail_ie -# @pytest.mark.xfail_edge(reason="Fails on Travis") -# @pytest.mark.xfail_firefox(reason="Fails on Travis") -# @pytest.mark.xfail_remote(reason="Fails on Travis") # def test_should_maximize_the_window(driver): # resize_timeout = 5 # wait = WebDriverWait(driver, resize_timeout) @@ -138,8 +135,6 @@ def test_set_window_rect_throws_when_height_and_width_are_0(driver): # @pytest.mark.xfail_safari(raises=WebDriverException, # reason='Fullscreen command not implemented') -# @pytest.mark.skipif(os.environ.get('TRAVIS') == 'true', -# reason='Fullscreen command causes Travis to hang') # @pytest.mark.no_driver_after_test # def test_should_fullscreen_the_current_window(driver): # start_width = driver.execute_script('return window.innerWidth;') @@ -161,8 +156,6 @@ def test_set_window_rect_throws_when_height_and_width_are_0(driver): # @pytest.mark.xfail_safari(raises=WebDriverException, # reason='Minimize command not implemented') -# @pytest.mark.skipif(os.environ.get('TRAVIS') == 'true', -# reason='Minimize command causes Travis to hang') # @pytest.mark.no_driver_after_test # def test_should_minimize_the_current_window(driver): # driver.minimize_window() From 1c7aecc258ae0fa33762839beac72e00d9ec10b1 Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Sat, 4 Oct 2025 09:36:31 -0400 Subject: [PATCH 2/2] [py] Re-add some markers --- py/test/selenium/webdriver/common/alerts_tests.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/py/test/selenium/webdriver/common/alerts_tests.py b/py/test/selenium/webdriver/common/alerts_tests.py index b42f270aa890e..c3ef08fa082c5 100644 --- a/py/test/selenium/webdriver/common/alerts_tests.py +++ b/py/test/selenium/webdriver/common/alerts_tests.py @@ -157,6 +157,8 @@ def test_alert_should_not_allow_additional_commands_if_dimissed(driver, pages): alert.text +@pytest.mark.xfail_firefox +@pytest.mark.xfail_remote @pytest.mark.xfail_safari def test_should_allow_users_to_accept_an_alert_in_aframe(driver, pages): pages.load("alerts.html") @@ -169,6 +171,8 @@ def test_should_allow_users_to_accept_an_alert_in_aframe(driver, pages): assert "Testing Alerts" == driver.title +@pytest.mark.xfail_firefox +@pytest.mark.xfail_remote @pytest.mark.xfail_safari def test_should_allow_users_to_accept_an_alert_in_anested_frame(driver, pages): pages.load("alerts.html")