From ae87fe61e6ac06962cf04a9a26039171d46d050e Mon Sep 17 00:00:00 2001
From: Michael Render <render.michael@gmail.com>
Date: Tue, 7 Oct 2025 20:49:06 -0400
Subject: [PATCH 1/2] [dotnet] Replace lazy caching mechanism in BiDi's
 constructor with simple initialization

---
 dotnet/src/webdriver/BiDi/BiDi.cs | 44 ++++++++++++++++---------------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/dotnet/src/webdriver/BiDi/BiDi.cs b/dotnet/src/webdriver/BiDi/BiDi.cs
index b80652d52bd20..5b66e8aeedcbd 100644
--- a/dotnet/src/webdriver/BiDi/BiDi.cs
+++ b/dotnet/src/webdriver/BiDi/BiDi.cs
@@ -17,15 +17,14 @@
 // under the License.
 // </copyright>
 
+using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
-using System.Collections.Concurrent;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using System.Threading;
 using System.Threading.Tasks;
-using OpenQA.Selenium.BiDi.Communication;
-using OpenQA.Selenium.BiDi.Communication.Json;
-using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 namespace OpenQA.Selenium.BiDi;
 
@@ -35,8 +34,6 @@ public sealed class BiDi : IAsyncDisposable
     private readonly JsonSerializerOptions _jsonOptions;
     private readonly BiDiJsonSerializerContext _jsonContext;
 
-    private readonly ConcurrentDictionary<Type, Module> _modules = [];
-
     private BiDi(string url)
     {
         var uri = new Uri(url);
@@ -68,32 +65,37 @@ private BiDi(string url)
         _jsonContext = new BiDiJsonSerializerContext(_jsonOptions);
 
         _broker = new Broker(this, uri, _jsonOptions);
+        SessionModule = Module.Create<Session.SessionModule>(this, _broker, _jsonOptions, _jsonContext);
+        BrowsingContext = Module.Create<BrowsingContext.BrowsingContextModule>(this, _broker, _jsonOptions, _jsonContext);
+        Browser = Module.Create<Browser.BrowserModule>(this, _broker, _jsonOptions, _jsonContext);
+        Network = Module.Create<Network.NetworkModule>(this, _broker, _jsonOptions, _jsonContext);
+        InputModule = Module.Create<Input.InputModule>(this, _broker, _jsonOptions, _jsonContext);
+        Script = Module.Create<Script.ScriptModule>(this, _broker, _jsonOptions, _jsonContext);
+        Log = Module.Create<Log.LogModule>(this, _broker, _jsonOptions, _jsonContext);
+        Storage = Module.Create<Storage.StorageModule>(this, _broker, _jsonOptions, _jsonContext);
+        WebExtension = Module.Create<WebExtension.WebExtensionModule>(this, _broker, _jsonOptions, _jsonContext);
+        Emulation = Module.Create<Emulation.EmulationModule>(this, _broker, _jsonOptions, _jsonContext);
     }
 
-    internal Session.SessionModule SessionModule => AsModule<Session.SessionModule>();
-
-    public BrowsingContext.BrowsingContextModule BrowsingContext => AsModule<BrowsingContext.BrowsingContextModule>();
+    internal Session.SessionModule SessionModule { get; }
 
-    public Browser.BrowserModule Browser => AsModule<Browser.BrowserModule>();
+    public BrowsingContext.BrowsingContextModule BrowsingContext { get; }
 
-    public Network.NetworkModule Network => AsModule<Network.NetworkModule>();
+    public Browser.BrowserModule Browser { get; }
 
-    internal Input.InputModule InputModule => AsModule<Input.InputModule>();
+    public Network.NetworkModule Network { get; }
 
-    public Script.ScriptModule Script => AsModule<Script.ScriptModule>();
+    internal Input.InputModule InputModule { get; }
 
-    public Log.LogModule Log => AsModule<Log.LogModule>();
+    public Script.ScriptModule Script { get; }
 
-    public Storage.StorageModule Storage => AsModule<Storage.StorageModule>();
+    public Log.LogModule Log { get; }
 
-    public WebExtension.WebExtensionModule WebExtension => AsModule<WebExtension.WebExtensionModule>();
+    public Storage.StorageModule Storage { get; }
 
-    public Emulation.EmulationModule Emulation => AsModule<Emulation.EmulationModule>();
+    public WebExtension.WebExtensionModule WebExtension { get; }
 
-    public TModule AsModule<TModule>() where TModule : Module, new()
-    {
-        return (TModule)_modules.GetOrAdd(typeof(TModule), _ => Module.Create<TModule>(this, _broker, _jsonOptions, _jsonContext));
-    }
+    public Emulation.EmulationModule Emulation { get; }
 
     public Task<Session.StatusResult> StatusAsync()
     {

From 7865500ec8aaef0866af0c2ea2b10c000633d7ff Mon Sep 17 00:00:00 2001
From: Michael Render <render.michael@gmail.com>
Date: Tue, 7 Oct 2025 21:04:40 -0400
Subject: [PATCH 2/2] Revert unnecessary changes

---
 dotnet/src/webdriver/BiDi/BiDi.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dotnet/src/webdriver/BiDi/BiDi.cs b/dotnet/src/webdriver/BiDi/BiDi.cs
index 5b66e8aeedcbd..448e0ea85bf48 100644
--- a/dotnet/src/webdriver/BiDi/BiDi.cs
+++ b/dotnet/src/webdriver/BiDi/BiDi.cs
@@ -17,14 +17,14 @@
 // under the License.
 // </copyright>
 
-using OpenQA.Selenium.BiDi.Communication;
-using OpenQA.Selenium.BiDi.Communication.Json;
-using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 using System;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using System.Threading;
 using System.Threading.Tasks;
+using OpenQA.Selenium.BiDi.Communication;
+using OpenQA.Selenium.BiDi.Communication.Json;
+using OpenQA.Selenium.BiDi.Communication.Json.Converters;
 
 namespace OpenQA.Selenium.BiDi;