From d3d7994d7931835af2ace998dc6f00bae68b347a Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Mon, 13 Oct 2025 19:40:45 -0400 Subject: [PATCH 1/2] [py] Raise NotImplementedError when deleting downloads in driver subclasses --- py/selenium/webdriver/chromium/webdriver.py | 3 +++ py/selenium/webdriver/ie/webdriver.py | 3 +++ py/selenium/webdriver/safari/webdriver.py | 3 +++ py/selenium/webdriver/webkitgtk/webdriver.py | 3 +++ py/selenium/webdriver/wpewebkit/webdriver.py | 3 +++ 5 files changed, 15 insertions(+) diff --git a/py/selenium/webdriver/chromium/webdriver.py b/py/selenium/webdriver/chromium/webdriver.py index c2bd3f945a3ca..59700c1a24803 100644 --- a/py/selenium/webdriver/chromium/webdriver.py +++ b/py/selenium/webdriver/chromium/webdriver.py @@ -230,3 +230,6 @@ def download_file(self, *args, **kwargs): def get_downloadable_files(self, *args, **kwargs): raise NotImplementedError + + def delete_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/ie/webdriver.py b/py/selenium/webdriver/ie/webdriver.py index 16e9e7ea95118..1454eb2af90d9 100644 --- a/py/selenium/webdriver/ie/webdriver.py +++ b/py/selenium/webdriver/ie/webdriver.py @@ -80,3 +80,6 @@ def download_file(self, *args, **kwargs): def get_downloadable_files(self, *args, **kwargs): raise NotImplementedError + + def delete_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/safari/webdriver.py b/py/selenium/webdriver/safari/webdriver.py index d7b52a03ed245..43d577357ed54 100644 --- a/py/selenium/webdriver/safari/webdriver.py +++ b/py/selenium/webdriver/safari/webdriver.py @@ -113,3 +113,6 @@ def download_file(self, *args, **kwargs): def get_downloadable_files(self, *args, **kwargs): raise NotImplementedError + + def delete_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/webkitgtk/webdriver.py b/py/selenium/webdriver/webkitgtk/webdriver.py index 8c2f45e891c7b..a7d80ee32abaa 100644 --- a/py/selenium/webdriver/webkitgtk/webdriver.py +++ b/py/selenium/webdriver/webkitgtk/webdriver.py @@ -64,3 +64,6 @@ def download_file(self, *args, **kwargs): def get_downloadable_files(self, *args, **kwargs): raise NotImplementedError + + def delete_downloadable_files(self, *args, **kwargs): + raise NotImplementedError diff --git a/py/selenium/webdriver/wpewebkit/webdriver.py b/py/selenium/webdriver/wpewebkit/webdriver.py index 8cae93d2c9f15..a14959075d6ed 100644 --- a/py/selenium/webdriver/wpewebkit/webdriver.py +++ b/py/selenium/webdriver/wpewebkit/webdriver.py @@ -64,3 +64,6 @@ def download_file(self, *args, **kwargs): def get_downloadable_files(self, *args, **kwargs): raise NotImplementedError + + def delete_downloadable_files(self, *args, **kwargs): + raise NotImplementedError From 74a78f0184df46a82c0ad91edb386c3aed5dac2c Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Mon, 13 Oct 2025 19:47:52 -0400 Subject: [PATCH 2/2] [py] Add to Firefox driver too --- py/selenium/webdriver/firefox/webdriver.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/py/selenium/webdriver/firefox/webdriver.py b/py/selenium/webdriver/firefox/webdriver.py index 7aabafcecc359..f8cc1418ee38b 100644 --- a/py/selenium/webdriver/firefox/webdriver.py +++ b/py/selenium/webdriver/firefox/webdriver.py @@ -226,3 +226,6 @@ def download_file(self, *args, **kwargs): def get_downloadable_files(self, *args, **kwargs): raise NotImplementedError + + def delete_downloadable_files(self, *args, **kwargs): + raise NotImplementedError