From c56ad9ad6cc01943851453f7c7201b5ca4b9da5c Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Tue, 14 Oct 2025 09:46:39 -0400 Subject: [PATCH 1/2] [py] Fix default rpId in virtual authenticator --- py/selenium/webdriver/common/virtual_authenticator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/selenium/webdriver/common/virtual_authenticator.py b/py/selenium/webdriver/common/virtual_authenticator.py index f6b0f4e926ac0..b567a72a35b5c 100644 --- a/py/selenium/webdriver/common/virtual_authenticator.py +++ b/py/selenium/webdriver/common/virtual_authenticator.py @@ -180,7 +180,7 @@ def to_dict(self) -> dict[str, Any]: def from_dict(cls, data: dict[str, Any]) -> "Credential": _id = urlsafe_b64decode(f"{data['credentialId']}==") is_resident_credential = bool(data["isResidentCredential"]) - rp_id = data["rpId"] + rp_id = data.get("rpId", None) private_key = urlsafe_b64decode(f"{data['privateKey']}==") sign_count = int(data["signCount"]) user_handle = urlsafe_b64decode(f"{data['userHandle']}==") if data.get("userHandle", None) else None From 8899e132561c84b01d297e86ad10faa1673ef16a Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Tue, 14 Oct 2025 10:02:56 -0400 Subject: [PATCH 2/2] [py] Fix type hint --- py/selenium/webdriver/common/virtual_authenticator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/selenium/webdriver/common/virtual_authenticator.py b/py/selenium/webdriver/common/virtual_authenticator.py index b567a72a35b5c..c0ae055e1e068 100644 --- a/py/selenium/webdriver/common/virtual_authenticator.py +++ b/py/selenium/webdriver/common/virtual_authenticator.py @@ -80,7 +80,7 @@ def __init__( self, credential_id: bytes, is_resident_credential: bool, - rp_id: str, + rp_id: Optional[str], user_handle: Optional[bytes], private_key: bytes, sign_count: int,