From c44f90ec9b74ef62df55a0157076b1e4a6df2361 Mon Sep 17 00:00:00 2001 From: Earlopain <14981592+Earlopain@users.noreply.github.com> Date: Wed, 15 Oct 2025 13:43:10 +0200 Subject: [PATCH 1/2] [rb] Remove `prism` dependency This project does not use prism at all. At most it is being used by rubocop during local development. It was added in https://github.com/SeleniumHQ/selenium/pull/16357 but it is unclear to me why. I just bumped it for this repo, perhaps that JRuby issue has since been fixed. Either way, it should not be part of the gemspec. --- MODULE.bazel | 2 +- rb/Gemfile.lock | 3 +-- rb/selenium-webdriver.gemspec | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index e85221f5839ed..e0621eb9b019c 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -318,7 +318,7 @@ ruby.bundle_fetch( "parser-3.3.9.0": "94d6929354b1a6e3e1f89d79d4d302cc8f5aa814431a6c9c7e0623335d7687f2", "pp-0.6.2": "947ec3120c6f92195f8ee8aa25a7b2c5297bb106d83b41baa02983686577b6ff", "prettyprint-0.2.0": "2bc9e15581a94742064a3cc8b0fb9d45aae3d03a1baa6ef80922627a0766f193", - "prism-1.4.0": "dc0e3e00e93160213dc2a65519d9002a4a1e7b962db57d444cf1a71565bb703e", + "prism-1.5.2": "192741663a55af1ac1b987caa1092deb666e4ff46a30c5064ad5456acd05df1d", "psych-5.2.6": "814328aa5dcb6d604d32126a20bc1cbcf05521a5b49dbb1a8b30a07e580f316e", "psych-5.2.6-java": "0a5f65d47ed1ae3475d062b254e7b2035a259eac578038016d62172dd4cfbd91", "public_suffix-6.0.2": "bfa7cd5108066f8c9602e0d6d4114999a5df5839a63149d3e8b0f9c1d3558394", diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock index 763aed52804e0..6f008b9f5e2f9 100644 --- a/rb/Gemfile.lock +++ b/rb/Gemfile.lock @@ -7,7 +7,6 @@ PATH base64 (~> 0.2) json (<= 2.13.2) logger (~> 1.4) - prism (~> 1.0, < 1.5) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 4.0) websocket (~> 1.0) @@ -85,7 +84,7 @@ GEM pp (0.6.2) prettyprint prettyprint (0.2.0) - prism (1.4.0) + prism (1.5.2) psych (5.2.6) date stringio diff --git a/rb/selenium-webdriver.gemspec b/rb/selenium-webdriver.gemspec index 39e1fe18c91f5..3b1802be66107 100644 --- a/rb/selenium-webdriver.gemspec +++ b/rb/selenium-webdriver.gemspec @@ -52,7 +52,6 @@ Gem::Specification.new do |s| s.add_dependency 'base64', ['~> 0.2'] s.add_dependency 'json', ['<= 2.13.2'] s.add_dependency 'logger', ['~> 1.4'] - s.add_dependency 'prism', ['~> 1.0', '< 1.5'] s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5'] s.add_dependency 'rubyzip', ['>= 1.2.2', '< 4.0'] s.add_dependency 'websocket', ['~> 1.0'] From 3e3b2f173c52479fb6a6924b385644afb4881ee2 Mon Sep 17 00:00:00 2001 From: Earlopain <14981592+Earlopain@users.noreply.github.com> Date: Wed, 15 Oct 2025 14:26:49 +0200 Subject: [PATCH 2/2] Pin prism to 1.4.0 for the project MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It fails to build with the following error: src/prism.c: In function ‘context_terminator’: src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Werror=sign-conversion] 8651 | return token->type < 32 && (context_terminators[context] & (1 << token->type)); | ^ cc1: all warnings being treated as errors --- MODULE.bazel | 2 +- rb/Gemfile | 4 ++++ rb/Gemfile.lock | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index e0621eb9b019c..e85221f5839ed 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -318,7 +318,7 @@ ruby.bundle_fetch( "parser-3.3.9.0": "94d6929354b1a6e3e1f89d79d4d302cc8f5aa814431a6c9c7e0623335d7687f2", "pp-0.6.2": "947ec3120c6f92195f8ee8aa25a7b2c5297bb106d83b41baa02983686577b6ff", "prettyprint-0.2.0": "2bc9e15581a94742064a3cc8b0fb9d45aae3d03a1baa6ef80922627a0766f193", - "prism-1.5.2": "192741663a55af1ac1b987caa1092deb666e4ff46a30c5064ad5456acd05df1d", + "prism-1.4.0": "dc0e3e00e93160213dc2a65519d9002a4a1e7b962db57d444cf1a71565bb703e", "psych-5.2.6": "814328aa5dcb6d604d32126a20bc1cbcf05521a5b49dbb1a8b30a07e580f316e", "psych-5.2.6-java": "0a5f65d47ed1ae3475d062b254e7b2035a259eac578038016d62172dd4cfbd91", "public_suffix-6.0.2": "bfa7cd5108066f8c9602e0d6d4114999a5df5839a63149d3e8b0f9c1d3558394", diff --git a/rb/Gemfile b/rb/Gemfile index 5c2c1d11f5954..310fb1a091421 100644 --- a/rb/Gemfile +++ b/rb/Gemfile @@ -10,3 +10,7 @@ gem 'activesupport', '~> 7.0', require: false, platforms: %i[mri mingw x64_mingw gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw] gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw] gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw] + +# Prism staring with 1.5 fails to build with the following error: +# src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Werror=sign-conversion] +gem 'prism', ['~> 1.0', '< 1.5'] diff --git a/rb/Gemfile.lock b/rb/Gemfile.lock index 6f008b9f5e2f9..f408ef7c46a1e 100644 --- a/rb/Gemfile.lock +++ b/rb/Gemfile.lock @@ -84,7 +84,7 @@ GEM pp (0.6.2) prettyprint prettyprint (0.2.0) - prism (1.5.2) + prism (1.4.0) psych (5.2.6) date stringio @@ -200,6 +200,7 @@ DEPENDENCIES curb (~> 1.0.5) debug (~> 1.7) git (~> 1.19) + prism (~> 1.0, < 1.5) rack (~> 2.0) rake (~> 13.0) rspec (~> 3.0)