From 6188f604872518b5c400b4bba69718e26185a4ba Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Sat, 15 Nov 2025 20:14:42 +0300 Subject: [PATCH 1/2] [dotnet] [bidi] Possibility to reset viewport --- .../src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs index 781f68d3765cf..19137043df0aa 100644 --- a/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs +++ b/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs @@ -18,13 +18,14 @@ // using OpenQA.Selenium.BiDi.Communication; +using System.Text.Json.Serialization; namespace OpenQA.Selenium.BiDi.BrowsingContext; internal sealed class SetViewportCommand(SetViewportParameters @params) : Command(@params, "browsingContext.setViewport"); -internal sealed record SetViewportParameters(BrowsingContext Context, Viewport? Viewport, double? DevicePixelRatio) : Parameters; +internal sealed record SetViewportParameters(BrowsingContext Context, [property: JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] Viewport? Viewport, double? DevicePixelRatio) : Parameters; public sealed class SetViewportOptions : CommandOptions { From 62db608c0d5f1e11018782c5da4f1cce90677598 Mon Sep 17 00:00:00 2001 From: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com> Date: Sun, 16 Nov 2025 19:48:50 +0300 Subject: [PATCH 2/2] Always send nullable viewport --- dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs b/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs index 19137043df0aa..4edbda999829b 100644 --- a/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs +++ b/dotnet/src/webdriver/BiDi/BrowsingContext/SetViewportCommand.cs @@ -25,7 +25,7 @@ namespace OpenQA.Selenium.BiDi.BrowsingContext; internal sealed class SetViewportCommand(SetViewportParameters @params) : Command(@params, "browsingContext.setViewport"); -internal sealed record SetViewportParameters(BrowsingContext Context, [property: JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] Viewport? Viewport, double? DevicePixelRatio) : Parameters; +internal sealed record SetViewportParameters(BrowsingContext Context, [property: JsonIgnore(Condition = JsonIgnoreCondition.Never)] Viewport? Viewport, double? DevicePixelRatio) : Parameters; public sealed class SetViewportOptions : CommandOptions {