/selenium

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement script execution for SVG documents in Firefox driver #22

Closed
wants to merge 2 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paroga @AutomatedTester
@paroga
Contributor

paroga commented Mar 6, 2013

When used with an SVG document the script element must be created
slightly different to work correctly.

The first commit is a already in pull request 21.
CLA signed

paroga added some commits Mar 6, 2013

@paroga
Add Utils.getMainDocumentElement for Firefox driver 
When the document is SVG instead of HTML the eventlistener for the
unload event needs to be added to documentElement instead of body.
This new function returns the corresponding element.
956fde0
@paroga
Implement script execution for SVG documents in Firefox driver 
When used with an SVG document the script element must be created
slightly different to work correctly.

Fixes issue #1276.
687be3c
@AutomatedTester

This comment has been minimized.

Show comment
Hide comment
@AutomatedTester

AutomatedTester Mar 6, 2013

Member

Can we please have a test to prevent future regressions
Member

AutomatedTester commented Mar 6, 2013

Can we please have a test to prevent future regressions

@paroga paroga closed this Mar 11, 2013

@paroga paroga deleted the paroga:issue1276 branch Mar 11, 2013

corevo added a commit to applitools/selenium that referenced this pull request Dec 11, 2017

@corevo
Merge pull request #22 from SeleniumHQ/compile-atoms 
Compile atoms
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
02f03e8

IlyaNaumovich added a commit to IlyaNaumovich/selenium that referenced this pull request Feb 11, 2018

@IlyaNaumovich
Attempt to improve BUCK #22
85b4566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment