Better default check for canBubble #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Google bigquery I found that your code was comparing the result of `typeof` with a variable named `undefined`. As typeof returns a string it would compare to a string with the content `'undefined'` Rewrote the line to a more simple one.
|
Thanks for catching this! Although the original intention is to check for undefined and then default to true, with your change if one passes in false it will change the value to true. Mind adjusting it accordingly? (Just changing undefined to "undefined" would do it) |
|
Aww - you are right ! Will change it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that your code was comparing the result of
typeofwith a variable namedundefined.As typeof returns a string it would compare to a string with the content
'undefined'Rewrote the line to a more simple one.