Update remote_connection.py #421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the connection is going to use https then don't modify the URL to use an IP address. Keep that sucker a hostname.
|
i take it this is a fix for #420 ? |
|
also can you confirm you've signed the cla |
|
Fix for #420. Just signed the cla. |
andreastt
added
Z-awaiting review
|
@lukeis can this still be merged? |
titusfortner
added a commit
to titusfortner/selenium
that referenced
this pull request
Nov 28, 2016
Closed
|
Replaced by #3179. If anything different needs to be done, please discuss it there, or rebase this code better than I did and we can re-open. |
davehunt
pushed a commit
to davehunt/selenium
that referenced
this pull request
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the connection is going to use https then don't modify the URL to use an IP address. Keep that sucker a hostname.