/selenium

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote_connection.py #421

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@jkohls @lukeis @llaskin @titusfortner @andreastt
@jkohls
Contributor

jkohls commented Apr 6, 2015

If the connection is going to use https then don't modify the URL to use an IP address. Keep that sucker a hostname.
@jkohls
Update remote_connection.py 
If the connection is going to use https then don't modify the URL to use an IP address. Keep that sucker a hostname.
42c3579
@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Apr 6, 2015

Member

i take it this is a fix for #420 ?
Member

lukeis commented Apr 6, 2015

i take it this is a fix for #420 ?

@jkohls jkohls referenced this pull request Apr 6, 2015

Closed

WebDriver with SSL on Python 2.7.9 #420

@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Apr 6, 2015

Member

also can you confirm you've signed the cla
Member

lukeis commented Apr 6, 2015

also can you confirm you've signed the cla
@jkohls

This comment has been minimized.

Show comment
Hide comment
@jkohls

jkohls Apr 6, 2015

Contributor

Fix for #420. Just signed the cla.
Contributor

jkohls commented Apr 6, 2015

Fix for #420. Just signed the cla.

@andreastt andreastt added R-awaiting review C-rb labels Apr 6, 2015

@titusfortner titusfortner added C-py and removed C-rb labels Sep 8, 2015

@llaskin

This comment has been minimized.

Show comment
Hide comment
@llaskin

llaskin Nov 14, 2016

Contributor

@lukeis can this still be merged?
Contributor

llaskin commented Nov 14, 2016

@lukeis can this still be merged?

titusfortner added a commit to titusfortner/selenium that referenced this pull request Nov 28, 2016

@titusfortner
[py] attempt to maintain intent of PR #421 after incomplete rebase
403afeb

@titusfortner titusfortner referenced this pull request Nov 28, 2016

Closed

Py remote connect #3179

@titusfortner

This comment has been minimized.

Show comment
Hide comment
@titusfortner

titusfortner Nov 29, 2016

Member

Replaced by #3179. If anything different needs to be done, please discuss it there, or rebase this code better than I did and we can re-open.
Member

titusfortner commented Nov 29, 2016

Replaced by #3179. If anything different needs to be done, please discuss it there, or rebase this code better than I did and we can re-open.

@titusfortner titusfortner closed this Nov 29, 2016

davehunt added a commit to davehunt/selenium that referenced this pull request Nov 30, 2016

@titusfortner @davehunt
[py] attempt to maintain intent of PR #421 after incomplete rebase
Verified
This commit was signed with a verified signature.
@davehunt davehunt Dave Hunt
GPG key ID: 4000D32ABB02F959 Learn about signing commits
b288c21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment