From aa52073be4e8059edcae74cf249187f64a6d1a02 Mon Sep 17 00:00:00 2001 From: Chris Ward Date: Thu, 18 Jan 2018 17:19:47 +0000 Subject: [PATCH 1/2] Syntax highlighting for JavasScript examples Uses the GitHub syntax highlighting for the readme.md --- javascript/node/selenium-webdriver/README.md | 56 +++++++++++--------- 1 file changed, 30 insertions(+), 26 deletions(-) diff --git a/javascript/node/selenium-webdriver/README.md b/javascript/node/selenium-webdriver/README.md index 60e30a57e716d..49f6e1cb4d609 100644 --- a/javascript/node/selenium-webdriver/README.md +++ b/javascript/node/selenium-webdriver/README.md @@ -30,19 +30,20 @@ Safari 10 before testing. The sample below and others are included in the `example` directory. You may also find the tests for selenium-webdriver informative. - - const {Builder, By, Key, until} = require('selenium-webdriver'); - - (async function example() { - let driver = await new Builder().forBrowser('firefox').build(); - try { - await driver.get('http://www.google.com/ncr'); - await driver.findElement(By.name('q')).sendKeys('webdriver', Key.RETURN); - await driver.wait(until.titleIs('webdriver - Google Search'), 1000); - } finally { - await driver.quit(); - } - })(); +```javascript +const {Builder, By, Key, until} = require('selenium-webdriver'); + +(async function example() { + let driver = await new Builder().forBrowser('firefox').build(); + try { + await driver.get('http://www.google.com/ncr'); + await driver.findElement(By.name('q')).sendKeys('webdriver', Key.RETURN); + await driver.wait(until.titleIs('webdriver - Google Search'), 1000); + } finally { + await driver.quit(); + } +})(); +``` ### Using the Builder API @@ -51,15 +52,17 @@ instances. Rather than clutter your code with branches for the various browsers, the builder lets you set all options in one flow. When you call `Builder#build()`, all options irrelevant to the selected browser are dropped: - const webdriver = require('selenium-webdriver'); - const chrome = require('selenium-webdriver/chrome'); - const firefox = require('selenium-webdriver/firefox'); +```javascript +const webdriver = require('selenium-webdriver'); +const chrome = require('selenium-webdriver/chrome'); +const firefox = require('selenium-webdriver/firefox'); - let driver = new webdriver.Builder() - .forBrowser('firefox') - .setChromeOptions(/* ... */) - .setFirefoxOptions(/* ... */) - .build(); +let driver = new webdriver.Builder() + .forBrowser('firefox') + .setChromeOptions(/* ... */) + .setFirefoxOptions(/* ... */) + .build(); +``` Why would you want to configure options irrelevant to the target browser? The `Builder`'s API defines your _default_ configuration. You can change the target @@ -92,11 +95,12 @@ server with You may configure your tests to run against a remote server through the Builder API: - let driver = new webdriver.Builder() - .forBrowser('firefox') - .usingServer('http://localhost:4444/wd/hub') - .build(); - +```javascript +let driver = new webdriver.Builder() + .forBrowser('firefox') + .usingServer('http://localhost:4444/wd/hub') + .build(); +``` Or change the Builder's configuration at runtime with the `SELENIUM_REMOTE_URL` environment variable: From c53f0298970270a435b7ce48fd2067e0bbe73a59 Mon Sep 17 00:00:00 2001 From: Chris Ward Date: Thu, 18 Jan 2018 20:24:35 +0000 Subject: [PATCH 2/2] Add missing space between paragraph and snippet --- javascript/node/selenium-webdriver/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/javascript/node/selenium-webdriver/README.md b/javascript/node/selenium-webdriver/README.md index 49f6e1cb4d609..bfe90f8a39f24 100644 --- a/javascript/node/selenium-webdriver/README.md +++ b/javascript/node/selenium-webdriver/README.md @@ -30,6 +30,7 @@ Safari 10 before testing. The sample below and others are included in the `example` directory. You may also find the tests for selenium-webdriver informative. + ```javascript const {Builder, By, Key, until} = require('selenium-webdriver');