Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add executing custom command to Chrome Python bindings #5989
There's also just a
@lmtierney Whoops, the /goog/ rename fell through my stack. I'm not 100% sure historically why the endpoint was added, but it points to a commonly used internal function call that is used and I assume was not intended to be used publicly.
I did discuss this with other Chromium folks and I can submit a change to chromedriver to have the endpoint be in the correct /goog/ extension style by EOD today and it will be pushed in our next release.
Here is a bug tracking the issue.
I guess in this PR it makes sense to either
Either way, I can own the responsibility of either submitting a PR here or pinging Lucas if I can't figure out where add the name change once the next ChromeDriver is out :)
Sorry I was on vacation this past week or so. It looks like you've addressed @kereliuk's changes and we are planning on releasing a new version tomorrow so I'll pull it in now. The only thing we might think of changing is either changing the