/selenium

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new HtmlUnitDriver(BrowserVersion,boolean) #727

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@asashour @lukeis @ddavison
@asashour
Contributor

asashour commented Jul 2, 2015

Currently there is a constructor
with BrowserVersion and another one with
boolean (JS enabling), however most users use
WebDriver driver = new HtmlUnitDriver()

And in this case WebDriver doesn't have
setBrowsreVersion/setJavascriptEnabled
@asashour
Add new HtmlUnitDriver(BrowserVersion,boolean) 
Currently there is a constructor
with BrowserVersion and another one with
boolean (JS enabling), however must users use
WebDriver driver = new HtmlUnitDriver()

And in this case WebDriver doesn't have
setBrowsreVersion/setJavascriptEnabled
86c126e

@ddavison ddavison added R-awaiting review C-java labels Jul 2, 2015

@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Jul 2, 2015

Member

merged with 3cff5f0
Member

lukeis commented Jul 2, 2015

merged with 3cff5f0

@lukeis lukeis closed this Jul 2, 2015

@asashour asashour deleted the HtmlUnit:htmlunitdriver_constructor branch Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment