Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable typo in firefox_profile.py #7656

Open
wants to merge 2 commits into
base: master
from

Conversation

@xaircore
Copy link
Contributor

xaircore commented Oct 6, 2019

fyle variable is typo for file

@xaircore xaircore changed the title Fix typo Fix variable typo in firefox_profile.py Oct 6, 2019
@xaircore

This comment has been minimized.

Copy link
Contributor Author

xaircore commented Oct 10, 2019

@ddavison Can review this PL?

Copy link
Member

cgoldberg left a comment

the typo was likely intentional... file is the name of a Python builtin function and re-using the name shadows the builtin.

Copy link
Contributor Author

xaircore left a comment

change file to file_name, for compatibility with python 2

@xaircore xaircore requested a review from cgoldberg Oct 10, 2019
@barancev barancev added the C-py label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.