Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common typo's #7659

Closed
wants to merge 3 commits into from

Conversation

@xaircore
Copy link
Contributor

xaircore commented Oct 6, 2019

xaircore added 2 commits Oct 6, 2019
@ddavison

This comment has been minimized.

Copy link
Member

ddavison commented Oct 8, 2019

LGTM 👍

Co-Authored-By: Dj <daniel.jj.davison@gmail.com>
@xaircore

This comment has been minimized.

Copy link
Contributor Author

xaircore commented Oct 8, 2019

@ddavison Thanks for suggested changes

@barancev

This comment has been minimized.

Copy link
Member

barancev commented Oct 11, 2019

Merged as e89b7d4, thank you for the contribution!

@barancev barancev closed this Oct 11, 2019
@xaircore xaircore deleted the xaircore:docs/fix-common-typos branch Oct 11, 2019
@@ -39,5 +39,5 @@ def add_action(self, action):
def clear_actions(self):
self.actions = []

def create_pause(self, duraton=0):
def create_pause(self, duration=0):

This comment has been minimized.

Copy link
@cgoldberg

cgoldberg Oct 11, 2019

Member

we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.

@barancev

This comment has been minimized.

Copy link
Member

barancev commented Oct 11, 2019

@cgoldberg I don't think anybody uses this create_pause method because it does nothing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.