Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common typo's #7659

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -39,5 +39,5 @@ def add_action(self, action):
def clear_actions(self):
self.actions = []

def create_pause(self, duraton=0):
def create_pause(self, duration=0):

This comment has been minimized.

Copy link
@cgoldberg

cgoldberg Oct 11, 2019

Member

we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.

pass
@@ -16,7 +16,7 @@
# under the License.

"""
The ApplicationCache implementaion.
The ApplicationCache implementation.
"""

from selenium.webdriver.remote.command import Command
@@ -33,7 +33,7 @@ class ApplicationCache(object):

def __init__(self, driver):
"""
Creates a new Aplication Cache.
Creates a new Application Cache.
:Args:
- driver: The WebDriver instance which performs user actions.
@@ -72,7 +72,7 @@ def connect_and_quit(self):

@classmethod
def is_connectable(self):
"""Trys to connect to the extension but do not retrieve context."""
"""Tries to connect to the extension but do not retrieve context."""
utils.is_connectable(self.profile.port)


@@ -59,7 +59,7 @@ def unzip_to_temp_dir(zip_file_name):
for zip_name in zf.namelist():
# We have no knowledge on the os where the zipped file was
# created, so we restrict to zip files with paths without
# charactor "\" and "/".
# character "\" and "/".
name = (zip_name.replace("\\", os.path.sep).
replace("/", os.path.sep))
dest = os.path.join(tempdir, name)
@@ -71,7 +71,7 @@ def unzip_to_temp_dir(zip_file_name):
for zip_name in zf.namelist():
# We have no knowledge on the os where the zipped file was
# created, so we restrict to zip files with paths without
# charactor "\" and "/".
# character "\" and "/".
name = (zip_name.replace("\\", os.path.sep).
replace("/", os.path.sep))
dest = os.path.join(tempdir, name)
@@ -65,14 +65,14 @@ def testShouldReturnTheValueOfTheDisabledAttributeAsFalseIfNotSet(driver, pages)
assert pElement.is_enabled()


def testShouldReturnTheValueOfTheIndexAttrbuteEvenIfItIsMissing(driver, pages):
def testShouldReturnTheValueOfTheIndexAttributeEvenIfItIsMissing(driver, pages):
pages.load("formPage.html")
multiSelect = driver.find_element_by_id("multi")
options = multiSelect.find_elements_by_tag_name("option")
assert "1" == options[1].get_attribute("index")


def testShouldIndicateTheElementsThatAreDisabledAreNotis_enabled(driver, pages):
def testShouldIndicateTheElementsThatAreDisabledAreNotIs_enabled(driver, pages):
pages.load("formPage.html")
inputElement = driver.find_element_by_xpath("//input[@id='notWorking']")
assert not inputElement.is_enabled()
@@ -52,7 +52,7 @@ def testShouldSubmitAFormWhenAnyInputElementWithinThatFormIsSubmitted(driver, pa
WebDriverWait(driver, 3).until(EC.title_is("We Arrive Here"))


def testShouldSubmitAFormWhenAnyElementWihinThatFormIsSubmitted(driver, pages):
def testShouldSubmitAFormWhenAnyElementWithinThatFormIsSubmitted(driver, pages):
pages.load("formPage.html")
driver.find_element_by_xpath("//form/p").submit()
WebDriverWait(driver, 5).until(EC.title_is("We Arrive Here"))
@@ -62,7 +62,7 @@ def testShouldBeAbleToSelectMoreThanOneOptionFromASelectWhichAllowsMultipleChoic
assert option.is_selected() is True


def testShouldSelectFirstOptionaultIfNoneIsSelecte(driver, pages):
def testShouldSelectFirstOptionIfNoneIsSelected(driver, pages):
pages.load("formPage.html")
selectBox = driver.find_element(By.XPATH, "//select[@name='select-default']")
options = selectBox.find_elements(By.TAG_NAME, "option")
@@ -83,7 +83,7 @@ def testCanSelectElementsInOptGroup(driver, pages):
assert element.is_selected() is True


def testCanGetValueFromOptionViaAttributeWhenAttributeDoesntExis(driver, pages):
def testCanGetValueFromOptionViaAttributeWhenAttributeDoesntExist(driver, pages):
pages.load("formPage.html")
element = driver.find_element(By.CSS_SELECTOR, "select[name='select-default'] option")
assert element.get_attribute("value") == "One"
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.