Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comments for Safari referencing Chrome #7990

Merged
merged 2 commits into from Feb 8, 2020

Conversation

@trademark18
Copy link
Contributor

trademark18 commented Feb 3, 2020

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Comments in SafariDriver mention ChromeDriver.exe where safaridriver was probably intended.

Motivation and Context

Adds clarity and consistency to comments. I ran across this because the tooltip in VS showed the comments on these methods, and that's how I was learning the expected name of each driver executable. This one looked off.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x ] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Not sure if this impacts documentation or not. If something needs to be updated please let me know. Thanks!

Comments in SafariDriver mention ChromeDriver.exe where safaridriver was probably intended.
@claassistantio

This comment has been minimized.

Copy link

claassistantio commented Feb 3, 2020

CLA assistant check
All committers have signed the CLA.

@AutomatedTester AutomatedTester merged commit 543bc09 into SeleniumHQ:master Feb 8, 2020
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.