From d8caee5c932bb91352d5220ccd78985cf69ce8e8 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 10:33:18 +0100 Subject: [PATCH 01/23] Initial commit for governance doc --- GOVERNANCE.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 GOVERNANCE.md diff --git a/GOVERNANCE.md b/GOVERNANCE.md new file mode 100644 index 000000000000..2a3dae6d8c05 --- /dev/null +++ b/GOVERNANCE.md @@ -0,0 +1,11 @@ +# Governance + +The Selenium Project wants as much as possible to operate using procedures that +are fair, open, inviting, and ultimately good for the community. For that reason, +we find it valuable to codify some of the ways that the Project goes about its +day-to-day business. We want to make sure that no matter who you are, you have +the opportunity to contribute to Selenium. We want to make sure that no +corporation can exert undue influence on the community or hold the Project +hostage. And likewise, we want to make sure that corporations which benefit +from Selenium are also incentivized to give back. This document describes how +various types of contributors work within the Selenium project. From 3a988734dfa1606635f7f8658f625e47c357c419 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 11:04:54 +0100 Subject: [PATCH 02/23] Adding users, contributors and committers roles [skip ci] --- GOVERNANCE.md | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 2a3dae6d8c05..4ab1a2546edf 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -9,3 +9,99 @@ corporation can exert undue influence on the community or hold the Project hostage. And likewise, we want to make sure that corporations which benefit from Selenium are also incentivized to give back. This document describes how various types of contributors work within the Selenium project. + +## Roles and Responsibilities + +### Users + +Users are community members who have a need for the project. Anyone can be a +User; there are no special requirements. Common User contributions include: + +* Evangelizing the project (e.g., display a link on a website and raise +awareness through word-of-mouth) +* Informing strengths and weaknesses from a new user perspective +(e.g., raising a bug as a GitHub issue, proposing a new feature) +* Providing moral support (a "thank you" goes a long way). + +Users who continue to engage with the project and its community will often +become more and more involved. Such Users may find themselves becoming +Contributors, as described in the next section. + +### Contributors + +Contributors are community members who contribute in concrete ways to the project, +most often in the form of code and/or documentation. Anyone can become a Contributor, +and contributions can take many forms, e.g.: +* Help other users through any of the [communication channels](#communication-channels) +made for that purpose. +* Triage GitHub issues. +* Organize Selenium meetups. +* Organize and collaborate in Selenium Conferences. + +There is no expectation of commitment to the project, no specific skill requirements, +and no selection process. + +Some Contributors might have some basic privileges to the GitHub repos, based on +their type of contribution (e.g., close an issue after triaging it). + +Contributors have read-only access to source code and submit changes via pull +requests. Contributor pull requests have their contribution reviewed and merged +by a TLC member or a Committer. TLC members and Committers work with Contributors +to review their code and prepare it for merging. + +As Contributors gain experience and familiarity with the project, their profile within, +and commitment to, the community will increase. At some stage, they may find themselves +being nominated for the Committer role by an existing Committer or TLC member. + +### Project Committers + +Committers are community members who have shown that they are committed to the +continued development of the project through ongoing engagement with the community. +Committers are given push access to the project's GitHub repos where they +contribute to. + +Committers: + +* Should bring their proposals for large changes to the project's code first to +a GitHub issue, and all relevant committers should be pinged so they can weigh +in on the discussion if desired. +* Debates between committers about whether code should be merged should happen +in GitHub pull requests to keep the project decision history. +* In general any committer can review and merge a pull request. Committers +should only merge code they are qualified to review, which might entail pinging +another committer who has greater ownership over a specific code area. +* May label and close issues. + +To become a Committer: + +* One must have shown a willingness and ability to participate in the project as +a team player. +* Committers are expected to be respectful of every community member and to work +collaboratively in the spirit of inclusion. +* Have submitted a minimum of 10 qualifying pull requests. Where significant +technical weight is present and requires little effort to accept because it is +well documented and tested. + +New Committers can be nominated by any existing Committer or TLC member. Once +they have been nominated, there will be a vote by the TLC members. + +It is important to recognize that having the Committer role is a privilege, not +a right. That privilege must be earned and once earned, it can be removed by +the TLC members by a standard TLC motion. However, under normal circumstances +the Committer role will exist for as long as the Committer wishes to continue +engaging with the project. + +A Committer who shows an above-average level of contribution to the project, +particularly with respect to its strategic direction and long-term health, may +be nominated to become a TLC member, described below. + +#### Process for Adding Committers + +1. Add the GitHub user to relevant GitHub team: + * "selenium-committers" for the main Selenium repo + * "selenium-ide" for the Selenium IDE repo + * "documentation" for the website and documentation repo + * "docker-owners" for the Docker-Selenium repo +1. Invite to Slack team chat room (`selenium-committers`) +1. Tweet congratulations to the new committer from the SeleniumHQ Twitter account + From 489b011294b5a714ee135f7134fbea39532f466c Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 12:14:38 +0100 Subject: [PATCH 03/23] Adding description for the TLC --- GOVERNANCE.md | 72 ++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 68 insertions(+), 4 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 4ab1a2546edf..37cf6fe59ca3 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -98,10 +98,74 @@ be nominated to become a TLC member, described below. #### Process for Adding Committers 1. Add the GitHub user to relevant GitHub team: - * "selenium-committers" for the main Selenium repo - * "selenium-ide" for the Selenium IDE repo - * "documentation" for the website and documentation repo - * "docker-owners" for the Docker-Selenium repo + * `selenium-committers` for the main Selenium repo + * `selenium-ide` for the Selenium IDE repo + * `documentation` for the website and documentation repo + * `docker-owners` for the Docker-Selenium repo 1. Invite to Slack team chat room (`selenium-committers`) 1. Tweet congratulations to the new committer from the SeleniumHQ Twitter account + +### Technical Leadership Committee (TLC) + +The technical decisions and roadmap of the Selenium project are governed by +a Technical Leadership Committee (TLC) which is responsible for a high-level +technical guidance of the project. + +The TLC has final authority over this project including: + +* Technical direction +* Repository hosting +* Contribution policy (shared with the PLC) + +TSC seats are not time-limited. There is no fixed size of the TLC. The TLC +should be of such a size as to ensure adequate coverage of important areas +of expertise balanced with the ability to make decisions efficiently. + +The TLC may add additional members to the TLC by a standard TLC motion. + +A TLC member may be removed from the TLC by voluntary resignation, or by a stand +ard TLC motion. + +No more than 1/3 of the TLC members may be affiliated with the same employer. +If removal or resignation of a TLC member, or a change of employment by a TLC +member, creates a situation where more than 1/3 of the TLC membership shares an +employer, then the situation must be immediately remedied by the resignation or +removal of one or more TLC members affiliated with the over-represented employer(s). + +TLC members have additional responsibilities over and above those of a Committer. +These responsibilities ensure the project has a technical viability and sustainability +in a smooth way. TLC members are expected to review code contributions, approve +changes to this document, and manage the copyrights within the project outputs. + +TLC members fulfill all requirements of Committers, and also: + +* May merge external pull requests for accepted issues upon reviewing and approving +the changes. +* Push code directly to the repos or, when necessary, create and merge their own pull +requests once they have collected the feedback they deem necessary. +* Discuss once a month the technical status and project roadmap. + +To become a TLC member: + +* Work in a helpful and collaborative way with the community. +* Have given good feedback on others' submissions and displayed an overall understanding +of the code quality standards for the project. +* Commit to being a part of the community for the long-term. +* Have submitted a minimum of 20 qualifying pull requests. + +A Committer is invited to become a TLC member by existing TLC members. A nomination +will result in discussion and then a decision by the TLC. + +#### Process for Adding TLC Members + +1. Add the GitHub user to the "Selenium TLC" team +1. Set the GitHub user to have the "Owner" role for the SeleniumHQ organization +1. Invite to the Slack TLC chat room (`selenium-tlc`) +1. Add the TLC member to the different package distribution organizations + * NPM + * SonarType (maven) + * pypi.org + * rubygems.org + * nuget.org +1. Tweet congratulations to the new TLC member from the SeleniumHQ Twitter account From 4a1ad9ac150434cee793c9880874ca7419d16f6c Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 14:27:36 +0100 Subject: [PATCH 04/23] Adding PLC members section --- GOVERNANCE.md | 47 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 37cf6fe59ca3..957abce0fdea 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -159,7 +159,7 @@ will result in discussion and then a decision by the TLC. #### Process for Adding TLC Members -1. Add the GitHub user to the "Selenium TLC" team +1. Add the GitHub user to the `Selenium TLC` team 1. Set the GitHub user to have the "Owner" role for the SeleniumHQ organization 1. Invite to the Slack TLC chat room (`selenium-tlc`) 1. Add the TLC member to the different package distribution organizations @@ -169,3 +169,48 @@ will result in discussion and then a decision by the TLC. * rubygems.org * nuget.org 1. Tweet congratulations to the new TLC member from the SeleniumHQ Twitter account + +### Project Leadership Committee (PLC) + +The overall continuity and future of the project is overseen by the Project +Leadership Committee (PLC), which acts as a bridge between the Selenium project +and the Software Freedom Conservancy (SFC). + +Since there are many different facets to the Selenium project, the PLC wants to +reflect more than just people who sling code about. The PLC gets involved in +different ways, such as whenever the project spends money, enters legal agreements, +or has to deal with lawyers. Typically the PLC will discuss the topic with the rest +of the community, and then a voting session will take place. + +PLC seats are not time-limited. Only one person may be affiliated with the any +given employer can be on the PLC at a time. The PLC member count should be always +odd so that no votes are ever tied, an ideal minimum number is 5. PLC members +should also be active members of the community. + +To become a PLC member: + +* An existing PLC member steps down and suggests someone (or some people) to replace them. +* Be a committer or a contributor. +* Commit to being a part of the community for the long-term. +* The existing PLC consults with the TLC and the active Committers, who vote on whether or +not to add those people. + * No-one is ever suggested publicly without first discussing the idea with + them first (to make sure that they are okay with it). + + +The PLC has final authority over this project including: + +* Project governance and process (including this policy). +* Contribution policy (shared with the PLC). +* Budget and legal related issues. + +The PLC also should discuss once a month the overall status of the project and any pending or +upcoming topics. + +A PLC member may be removed from the PLC by voluntary resignation, or by a stand +ard TSC motion. + +#### Process for Adding PLC Members + +1. Invite to the Slack PLC chat room (`selenium-plc`) +1. Tweet congratulations to the new PLC member from the SeleniumHQ Twitter account From ba358f4a8700c474b099cce33770ce06fb5b62c7 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 15:00:09 +0100 Subject: [PATCH 05/23] Adding final part of the draft governance doc --- GOVERNANCE.md | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 957abce0fdea..1001831d0a18 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -214,3 +214,72 @@ ard TSC motion. 1. Invite to the Slack PLC chat room (`selenium-plc`) 1. Tweet congratulations to the new PLC member from the SeleniumHQ Twitter account + +## Communication Channels + +The project maintains various channels for providing information, supporting development +and enabling communication between team members. Adherence to the project's +[Code of Conduct](/CODE_OF_CONDUCT.md) is strictly mandatory for all types of communication +in these channels. + +- Twitter Account ([`@seleniumhq`](https://twitter.com/seleniumhq)): for communicating +and promoting news around the project or project related topics. +- [Chat Room](https://webchat.freenode.net/#selenium): chat for all Selenium users to seek +help and support on problems using the project. +- [Slack](https://seleniumhq.slack.com/join/shared_invite/enQtODAwOTUzOTM5OTEwLTZjZjgzN2ExOTBmZGE0NjkwYzA2Nzc0MjczMGYwYjdiNGQ5YjI0ZjdjYjFhMjVlMjFkZWJmNDYyMmU1OTYyM2Y): +mirrors the IRC Chat room and is also used by all Selenium users to seek help and support +on problems using the project. +- Project Committers Channel, `selenium-committers` in the Slack channel mentioned above: +private channel for members of the Project Committers team to discuss contributions and +organise other collaborative efforts. +- TLC Channel, `selenium-tlc` in the Slack channel mentioned above: +private channel for TLC members to discuss technical planning and technical project roadmap. +- PLC Channel, `selenium-plc` in the Slack channel mentioned above: +private channel for PLC members to overall project planning, roadmap and related issues. + +## Consensus Seeking Process + +The PLC and TLC follow a [Consensus Seeking](https://en.wikipedia.org/wiki/Consensus-seeking_decision-making) +decision making model. + +When an agenda item has appeared to reach a consensus, the moderator will ask +"Does anyone object?" as a final call for dissent from the consensus. + +If an agenda item cannot reach a consensus, a PLC/TLC member can call for either +a closing vote or a vote to table the issue to the next meeting. The call for a +vote must be approved by a majority of the TSC or else the discussion will continue. +Simple majority wins. + +## Sponsorship + +The Selenium project is a member of the Software Freedom Conservancy, a 501(c)3 non-profit +organization. The Conservancy has allowed us to pool organizational resources with other +projects, such as Inkscape, Samba, and Wine, in order to reduce the management overhead +associated with creating our own, dedicated legal entity. + +Please see more details at https://selenium.dev/sponsor/ + +## Commercial and Community Driven Projects + +The wide use of the tools provided by the Selenium project has created a large offer of +commercial services and open source/community driven projects. The Selenium project +enables and encourages anyone to start any type of project or service that has as its +objective to simplify and spread the use of Selenium across the community. + +Nevertheless, due to its open source, community and non-profit origin, the Selenium +project will only mention on its website projects of the same nature based on Selenium +or WebDriver. If a commercial tool or project wants to be mentioned in the Selenium website, +please see the [Sponsorship](#sponsorship) section of this document. + + +## Raising Issues Related to Governance + +This governance model necessarily leaves many situations unspecified. If questions arise +as to how a given situation should proceed according to the overall goals of the project, +the best thing to do is to open a GitHub issue and ping the PLC/TLC members. + +---- + +This work is a derivative of the [ESLint Project Governance Model](https://github.com/eslint/eslint/blob/master/docs/maintainer-guide/governance.md). + +This work is licensed under a [Creative Commons Attribution-ShareAlike 2.0 UK: England & Wales License](https://creativecommons.org/licenses/by-sa/2.0/uk/). From 6073d5bbf9273a2765996730c6478c910c9b1a5b Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 15:35:17 +0100 Subject: [PATCH 06/23] TLC members proposal --- GOVERNANCE.md | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 1001831d0a18..afd20ae308f3 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -105,6 +105,62 @@ be nominated to become a TLC member, described below. 1. Invite to Slack team chat room (`selenium-committers`) 1. Tweet congratulations to the new committer from the SeleniumHQ Twitter account +The current Committers are (divided by repo): + +Selenium IDE: +* [@corevo](https://github.com/corevo) +* [@manoj9788](https://github.com/manoj9788) +* [@shs96c](https://github.com/shs96c) + +Selenium: +* [@adamgoucher](https://github.com/adamgoucher) +* [@andreastt](https://github.com/andreastt) +* [@AutomatedTester](https://github.com/AutomatedTester) +* [@barancev](https://github.com/barancev) +* [@cgoldberg](https://github.com/cgoldberg) +* [@corevo](https://github.com/corevo) +* [@davehunt](https://github.com/davehunt) +* [@ddavison](https://github.com/ddavison) +* [@dfabulich](https://github.com/dfabulich) +* [@diemol](https://github.com/diemol) +* [@DominikDary](https://github.com/DominikDary) +* [@freynaud](https://github.com/freynaud) +* [@illicitonion](https://github.com/illicitonion) +* [@jarib](https://github.com/jarib) +* [@jimevans](https://github.com/jimevans) +* [@jleyba](https://github.com/jleyba) +* [@jlipps](https://github.com/jlipps) +* [@joshbruning](https://github.com/joshbruning) +* [@juangj](https://github.com/juangj) +* [@julianharty](https://github.com/julianharty) +* [@krosenvold](https://github.com/krosenvold) +* [@lmtierney](https://github.com/lmtierney) +* [@lukeis](https://github.com/lukeis) +* [@mach6](https://github.com/mach6) +* [@mtscout6](https://github.com/mtscout6) +* [@nirvdrum](https://github.com/nirvdrum) +* [@p0deje](https://github.com/p0deje) +* [@santiycr](https://github.com/santiycr) +* [@sevaseva](https://github.com/sevaseva) +* [@shs96c](https://github.com/shs96c) +* [@titusfortner](https://github.com/titusfortner) +* [@tourdedavetner](https://github.com/tourdedave) +* [@twalpole](https://github.com/twalpole) + +Selenium Site & Docs: +* [@ahunsberger](https://github.com/ahunsberger) +* [@ddavison](https://github.com/ddavison) +* [@diemol](https://github.com/diemol) +* [@lukeis](https://github.com/lukeis) +* [@manoj9788](https://github.com/manoj9788) + +Docker-Selenium: +* [@ddavison](https://github.com/ddavison) +* [@diemol](https://github.com/diemol) +* [@elgalu](https://github.com/elgalu) +* [@kayabendroth](https://github.com/kayabendroth) +* [@mtscout6](https://github.com/mtscout6) +* [@WillAbides](https://github.com/WillAbides) ### Technical Leadership Committee (TLC) @@ -170,6 +226,13 @@ will result in discussion and then a decision by the TLC. * nuget.org 1. Tweet congratulations to the new TLC member from the SeleniumHQ Twitter account +The current TLC members are: + +* [@barancev](https://github.com/barancev) +* [@jimevans](https://github.com/jimevans) +* [@manoj9788](https://github.com/manoj9788) +* [@shs96c](https://github.com/shs96c) + ### Project Leadership Committee (PLC) The overall continuity and future of the project is overseen by the Project @@ -215,6 +278,14 @@ ard TSC motion. 1. Invite to the Slack PLC chat room (`selenium-plc`) 1. Tweet congratulations to the new PLC member from the SeleniumHQ Twitter account +The current TLC members are: + +* [@barancev](https://github.com/barancev) +* [@jimevans](https://github.com/jimevans) +* [@shs96c](https://github.com/shs96c) +* [@titusfortner](https://github.com/titusfortner) + + ## Communication Channels The project maintains various channels for providing information, supporting development From 1fa5ef2817039e2a29d2220a2b2134daba02d14a Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Tue, 3 Dec 2019 16:02:52 +0100 Subject: [PATCH 07/23] Correcting TLC members proposal. --- GOVERNANCE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index afd20ae308f3..9d5b5a9657db 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -230,8 +230,8 @@ The current TLC members are: * [@barancev](https://github.com/barancev) * [@jimevans](https://github.com/jimevans) -* [@manoj9788](https://github.com/manoj9788) * [@shs96c](https://github.com/shs96c) +* [@titusfortner](https://github.com/titusfortner) ### Project Leadership Committee (PLC) @@ -278,12 +278,12 @@ ard TSC motion. 1. Invite to the Slack PLC chat room (`selenium-plc`) 1. Tweet congratulations to the new PLC member from the SeleniumHQ Twitter account -The current TLC members are: +The current PLC members are: * [@barancev](https://github.com/barancev) * [@jimevans](https://github.com/jimevans) +* [@manoj9788](https://github.com/manoj9788) * [@shs96c](https://github.com/shs96c) -* [@titusfortner](https://github.com/titusfortner) ## Communication Channels From 5025892e97a6a5a0980d550a1c059e70465273ee Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Mon, 3 Feb 2020 17:01:48 +0100 Subject: [PATCH 08/23] Update GOVERNANCE.md --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 9d5b5a9657db..8840fa6a03fd 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -174,7 +174,7 @@ The TLC has final authority over this project including: * Repository hosting * Contribution policy (shared with the PLC) -TSC seats are not time-limited. There is no fixed size of the TLC. The TLC +TLC seats are not time-limited. There is no fixed size of the TLC. The TLC should be of such a size as to ensure adequate coverage of important areas of expertise balanced with the ability to make decisions efficiently. From 42d227fd29dd61626bc2c8268ab6da88379b9505 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Mon, 3 Feb 2020 18:29:15 +0100 Subject: [PATCH 09/23] Update GOVERNANCE.md --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 8840fa6a03fd..caefbbf75278 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -208,7 +208,7 @@ To become a TLC member: * Have given good feedback on others' submissions and displayed an overall understanding of the code quality standards for the project. * Commit to being a part of the community for the long-term. -* Have submitted a minimum of 20 qualifying pull requests. +* Have submitted a minimum of 20 qualifying pull requests or pushed a minimum of 20 qualifying commits across the different projects (IDE, Docker-Selenium, Selenium, Site & Docs). A Committer is invited to become a TLC member by existing TLC members. A nomination will result in discussion and then a decision by the TLC. From 9ae925acb264713e0f44fd7ad56dc4408da20607 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 09:37:03 +0100 Subject: [PATCH 10/23] Addressing @lukeis comments, thanks! --- GOVERNANCE.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 9d5b5a9657db..4ad2bb5818ae 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -46,7 +46,8 @@ their type of contribution (e.g., close an issue after triaging it). Contributors have read-only access to source code and submit changes via pull requests. Contributor pull requests have their contribution reviewed and merged -by a TLC member or a Committer. TLC members and Committers work with Contributors +by a [Technical Leadership Committee (TLC)](#technical-leadership-committee-tlc) +member or a Committer. TLC members and Committers work with Contributors to review their code and prepare it for merging. As Contributors gain experience and familiarity with the project, their profile within, @@ -172,7 +173,7 @@ The TLC has final authority over this project including: * Technical direction * Repository hosting -* Contribution policy (shared with the PLC) +* Contribution policy (shared with the [Project Leadership Committee (PLC)](#project-leadership-committee-plc)) TSC seats are not time-limited. There is no fixed size of the TLC. The TLC should be of such a size as to ensure adequate coverage of important areas From 40efdccfdbcd6c7f74a1e9738086897efe0aff7a Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 10:10:30 +0100 Subject: [PATCH 11/23] Update GOVERNANCE.md Co-Authored-By: Daniel Wagner-Hall --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 3419a36f02af..e6ebab643304 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -265,7 +265,7 @@ not to add those people. The PLC has final authority over this project including: * Project governance and process (including this policy). -* Contribution policy (shared with the PLC). +* Contribution policy (shared with the TLC). * Budget and legal related issues. The PLC also should discuss once a month the overall status of the project and any pending or From c73a7f6da161d0d5627a394f0360df61645cf486 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 10:16:38 +0100 Subject: [PATCH 12/23] Update GOVERNANCE.md Co-Authored-By: Daniel Wagner-Hall --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index e6ebab643304..0f6b05063d11 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -272,7 +272,7 @@ The PLC also should discuss once a month the overall status of the project and a upcoming topics. A PLC member may be removed from the PLC by voluntary resignation, or by a stand -ard TSC motion. +ard PLC motion. #### Process for Adding PLC Members From af51034724ff8807afc3115a31c76fe1505b4267 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 10:18:34 +0100 Subject: [PATCH 13/23] Fixing wrapping, pointed out by @illicitonion, thanks! --- GOVERNANCE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 0f6b05063d11..75aaf4813944 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -181,8 +181,8 @@ of expertise balanced with the ability to make decisions efficiently. The TLC may add additional members to the TLC by a standard TLC motion. -A TLC member may be removed from the TLC by voluntary resignation, or by a stand -ard TLC motion. +A TLC member may be removed from the TLC by voluntary resignation, or by a +standard TLC motion. No more than 1/3 of the TLC members may be affiliated with the same employer. If removal or resignation of a TLC member, or a change of employment by a TLC @@ -271,8 +271,8 @@ The PLC has final authority over this project including: The PLC also should discuss once a month the overall status of the project and any pending or upcoming topics. -A PLC member may be removed from the PLC by voluntary resignation, or by a stand -ard PLC motion. +A PLC member may be removed from the PLC by voluntary resignation, or by a +standard PLC motion. #### Process for Adding PLC Members From 2d5cee3adcd0d3958bde728517f362e42ae237d2 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 17:48:29 +0100 Subject: [PATCH 14/23] Making more clear the difference between committers and TLC members rights. --- GOVERNANCE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 75aaf4813944..63d9f8d8dad4 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -198,7 +198,9 @@ changes to this document, and manage the copyrights within the project outputs. TLC members fulfill all requirements of Committers, and also: * May merge external pull requests for accepted issues upon reviewing and approving -the changes. +the changes without the need to ping other committers who might have greater ownership +over the affected code area, given that reviewing and accepting the pull request +does not require deep knowledge in the affected code area. * Push code directly to the repos or, when necessary, create and merge their own pull requests once they have collected the feedback they deem necessary. * Discuss once a month the technical status and project roadmap. From af41fd09acbb3cee692154163c692d9d771073a2 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 18:01:35 +0100 Subject: [PATCH 15/23] Update GOVERNANCE.md Co-Authored-By: Daniel Wagner-Hall --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 63d9f8d8dad4..7b6a4ce35c18 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -342,7 +342,7 @@ objective to simplify and spread the use of Selenium across the community. Nevertheless, due to its open source, community and non-profit origin, the Selenium project will only mention on its website projects of the same nature based on Selenium -or WebDriver. If a commercial tool or project wants to be mentioned in the Selenium website, +or WebDriver, except on the sponsors page. If a commercial tool or project wants to be mentioned in the Selenium website, please see the [Sponsorship](#sponsorship) section of this document. From 670c764b87744f79cdb7cd6d21dd61cf744cf3d9 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 18:02:11 +0100 Subject: [PATCH 16/23] Addressing more comments. --- GOVERNANCE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 7b6a4ce35c18..a13aa9922e14 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -182,7 +182,7 @@ of expertise balanced with the ability to make decisions efficiently. The TLC may add additional members to the TLC by a standard TLC motion. A TLC member may be removed from the TLC by voluntary resignation, or by a -standard TLC motion. +standard TLC or PLC motion. No more than 1/3 of the TLC members may be affiliated with the same employer. If removal or resignation of a TLC member, or a change of employment by a TLC @@ -248,7 +248,7 @@ different ways, such as whenever the project spends money, enters legal agreemen or has to deal with lawyers. Typically the PLC will discuss the topic with the rest of the community, and then a voting session will take place. -PLC seats are not time-limited. Only one person may be affiliated with the any +PLC seats are not time-limited. Only one person may be affiliated with any given employer can be on the PLC at a time. The PLC member count should be always odd so that no votes are ever tied, an ideal minimum number is 5. PLC members should also be active members of the community. From 27761bd1d2c7fe3942b6d79054f205a24ab90cc1 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 6 Feb 2020 18:13:06 +0100 Subject: [PATCH 17/23] Using "Consensus Seeking Process" instead of voting. --- GOVERNANCE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index a13aa9922e14..4d098a4027fe 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -84,7 +84,8 @@ technical weight is present and requires little effort to accept because it is well documented and tested. New Committers can be nominated by any existing Committer or TLC member. Once -they have been nominated, there will be a vote by the TLC members. +they have been nominated, the TLC members will seek a decision based on a +[Consensus Seeking Process](#consensus-seeking-process). It is important to recognize that having the Committer role is a privilege, not a right. That privilege must be earned and once earned, it can be removed by @@ -258,8 +259,8 @@ To become a PLC member: * An existing PLC member steps down and suggests someone (or some people) to replace them. * Be a committer or a contributor. * Commit to being a part of the community for the long-term. -* The existing PLC consults with the TLC and the active Committers, who vote on whether or -not to add those people. +* The existing PLC consults with the TLC and the active Committers, who will seek a decision +based on a [Consensus Seeking Process](#consensus-seeking-process) to add or not those people. * No-one is ever suggested publicly without first discussing the idea with them first (to make sure that they are okay with it). From 053337325bf1fc1b86eb5ae84ace4cac3c258a18 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Fri, 7 Feb 2020 11:37:13 +0100 Subject: [PATCH 18/23] Replacing `table` for a clear wording. Credits to @titusfortner --- GOVERNANCE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 4d098a4027fe..5e3473db4dba 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -321,9 +321,9 @@ When an agenda item has appeared to reach a consensus, the moderator will ask "Does anyone object?" as a final call for dissent from the consensus. If an agenda item cannot reach a consensus, a PLC/TLC member can call for either -a closing vote or a vote to table the issue to the next meeting. The call for a -vote must be approved by a majority of the TSC or else the discussion will continue. -Simple majority wins. +a closing vote or a vote to postpone further discussion on the issue until the next +meeting. The call for a vote must be approved by a majority of the TSC or else the +discussion will continue. Simple majority wins. ## Sponsorship From 056a31b3a6a81ed0e4aca4b62b7c2d4909721b58 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Thu, 13 Feb 2020 16:07:32 +0100 Subject: [PATCH 19/23] Adding the suggestions from @illicitonion. --- GOVERNANCE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 5e3473db4dba..8ad344da4e79 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -198,7 +198,7 @@ changes to this document, and manage the copyrights within the project outputs. TLC members fulfill all requirements of Committers, and also: -* May merge external pull requests for accepted issues upon reviewing and approving +* May merge pull requests for accepted issues upon reviewing and approving the changes without the need to ping other committers who might have greater ownership over the affected code area, given that reviewing and accepting the pull request does not require deep knowledge in the affected code area. @@ -249,8 +249,8 @@ different ways, such as whenever the project spends money, enters legal agreemen or has to deal with lawyers. Typically the PLC will discuss the topic with the rest of the community, and then a voting session will take place. -PLC seats are not time-limited. Only one person may be affiliated with any -given employer can be on the PLC at a time. The PLC member count should be always +PLC seats are not time-limited. Only one person on the PLC may be affiliated with +any given employer at a time. The PLC member count should be always odd so that no votes are ever tied, an ideal minimum number is 5. PLC members should also be active members of the community. From 0afceee99dbdcd1d733a43fd13836e145e1b9f7e Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Fri, 14 Feb 2020 11:27:55 +0100 Subject: [PATCH 20/23] Proposing a few more names for PLC and TLC. --- GOVERNANCE.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 8ad344da4e79..695692e1a3cd 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -236,6 +236,9 @@ The current TLC members are: * [@jimevans](https://github.com/jimevans) * [@shs96c](https://github.com/shs96c) * [@titusfortner](https://github.com/titusfortner) +* [@automatedtester](https://github.com/automatedtester) +* [@diemol](https://github.com/diemol) +* [@tourdedave](https://github.com/tourdedave) ### Project Leadership Committee (PLC) @@ -288,6 +291,7 @@ The current PLC members are: * [@jimevans](https://github.com/jimevans) * [@manoj9788](https://github.com/manoj9788) * [@shs96c](https://github.com/shs96c) +* [@mmerrell](https://github.com/mmerrell) ## Communication Channels From ea7fa0f46b10879506c567eabb0348243ec8e24b Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Fri, 21 Feb 2020 11:52:24 +0100 Subject: [PATCH 21/23] Update GOVERNANCE.md Co-Authored-By: Dj --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 695692e1a3cd..1c1aa5cc30c9 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -21,7 +21,7 @@ User; there are no special requirements. Common User contributions include: awareness through word-of-mouth) * Informing strengths and weaknesses from a new user perspective (e.g., raising a bug as a GitHub issue, proposing a new feature) -* Providing moral support (a "thank you" goes a long way). +* Providing moral support (a "thank you" goes a long way) Users who continue to engage with the project and its community will often become more and more involved. Such Users may find themselves becoming From c41bbf126620fbb7c0566e4273927843b57435f0 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Fri, 21 Feb 2020 11:55:41 +0100 Subject: [PATCH 22/23] Update GOVERNANCE.md Co-Authored-By: Dj --- GOVERNANCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 1c1aa5cc30c9..2d47a318bcad 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -73,7 +73,7 @@ should only merge code they are qualified to review, which might entail pinging another committer who has greater ownership over a specific code area. * May label and close issues. -To become a Committer: +#### Becoming a committer * One must have shown a willingness and ability to participate in the project as a team player. From 45c1a3811692c735c32af109e16b5e77fd367306 Mon Sep 17 00:00:00 2001 From: Diego Molina Date: Wed, 26 Feb 2020 10:54:09 +0100 Subject: [PATCH 23/23] Clarifying the criteria to become a committer. --- GOVERNANCE.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 2d47a318bcad..a19659e815dc 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -79,9 +79,13 @@ another committer who has greater ownership over a specific code area. a team player. * Committers are expected to be respectful of every community member and to work collaboratively in the spirit of inclusion. -* Have submitted a minimum of 10 qualifying pull requests. Where significant -technical weight is present and requires little effort to accept because it is -well documented and tested. +* Have submitted sufficient substantive contributions to one or more of the +different projects (IDE, Docker-Selenium, Selenium, Site & Docs). For +technical contributions, enough weight is present and requires little effort to +accept because it is well documented and tested. Normally 10 substantive +contributions are needed to qualify as a candidate to be a committer, but there +could be cases where the contributions are substantial enough that a fewer +amount is also acceptable. New Committers can be nominated by any existing Committer or TLC member. Once they have been nominated, the TLC members will seek a decision based on a @@ -212,7 +216,8 @@ To become a TLC member: * Have given good feedback on others' submissions and displayed an overall understanding of the code quality standards for the project. * Commit to being a part of the community for the long-term. -* Have submitted a minimum of 20 qualifying pull requests or pushed a minimum of 20 qualifying commits across the different projects (IDE, Docker-Selenium, Selenium, Site & Docs). +* Have submitted a minimum of 20 substantive pull requests or pushed a minimum of 20 + substantive commits across the different projects (IDE, Docker-Selenium, Selenium, Site & Docs). A Committer is invited to become a TLC member by existing TLC members. A nomination will result in discussion and then a decision by the TLC.