Skip to content

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented Jan 2, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Description

PR #143 Has gone stale. This PR replaces #143

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@harsha509
Copy link
Member Author

Thank you @diemol

@diemol diemol merged commit 259c3fb into SeleniumHQ:master Jan 8, 2020
@harsha509 harsha509 deleted the kotlin_codeChanges branch January 13, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants