Skip to content

Conversation

@sidsiddiqi
Copy link
Contributor

@sidsiddiqi sidsiddiqi commented Jan 5, 2020

A very small yet obvious grammatical fix to a sentence on this page.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

A very small yet obvious grammatical fix to a sentence on this page.
@claassistantio
Copy link

claassistantio commented Jan 5, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sidsiddiqi ,

Thanks for the PR.

Can you please update text for other translated pages too.

Thanks,
Harsha

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidsiddiqi could you please update the other language pages which are still using the English version?

@boris779
Copy link
Contributor

Can I also do the missing changes? I checked out the patch-1 branch from @sidsiddiqi
How can I commit to this PR?

@harsha509
Copy link
Member

Hi @boris779,

This is a trivial change. We may need to give some more time for the author for the requested changes.

Thanks,
Harsha

@boris779
Copy link
Contributor

I've compared the files, also the other languages (for on_test_automation.xx.md) are a kind of outdated, I already changed it. Give me a call if you want to merge that.

@harsha509
Copy link
Member

Yes @boris779 , You can create a PR referencing this PR and giving credits to the original author.
This will do i think.

Thanks,
Harsha

@boris779 boris779 mentioned this pull request Jan 16, 2020
5 tasks
@boris779
Copy link
Contributor

Raised a PR #178 which was forked from @sidsiddiqi

@diemol
Copy link
Member

diemol commented Jan 16, 2020

Replaced by #178, thanks @boris779

@diemol diemol closed this Jan 16, 2020
diemol added a commit that referenced this pull request Jan 16, 2020
* Update on_test_automation.en.md

A very small yet obvious grammatical fix to a sentence on this page.

* Updated other languages to finish PR

Co-authored-by: sidsiddiqi <2281928+sidsiddiqi@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants