Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Adding shared capabilities platformName and acceptInsecureCerts #326

Merged
merged 4 commits into from Mar 18, 2020
Merged

Add: Adding shared capabilities platformName and acceptInsecureCerts #326

merged 4 commits into from Mar 18, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Mar 16, 2020 •
edited

Description

Adding shared capabilities platformName and 'acceptInsecureCerts' into sharedCapabilities.md

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

diemol
diemol requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509, I just left a comment.

docs_source_files/content/driver_idiosyncrasies/shared_capabilities.de.md Outdated Show resolved Hide resolved
@harsha509 harsha509 requested a review from diemol March 17, 2020 17:46
diemol
diemol requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments.

docs_source_files/content/driver_idiosyncrasies/shared_capabilities.de.md Outdated Show resolved Hide resolved
docs_source_files/content/driver_idiosyncrasies/shared_capabilities.de.md Outdated Show resolved Hide resolved
docs_source_files/content/driver_idiosyncrasies/shared_capabilities.de.md Outdated Show resolved Hide resolved
docs_source_files/content/driver_idiosyncrasies/shared_capabilities.de.md Outdated Show resolved Hide resolved
docs_source_files/content/driver_idiosyncrasies/shared_capabilities.de.md Outdated Show resolved Hide resolved
@harsha509
Copy link
Member Author

Apologies for the grammatical mistakes and spell errors, I will be careful going further.

Thanks for review @diemol and @cgoldberg

@harsha509 harsha509 requested a review from diemol March 17, 2020 17:57
diemol
diemol approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@diemol diemol merged commit 3ca1450 into SeleniumHQ:master Mar 18, 2020
@kzhirata kzhirata mentioned this pull request Mar 19, 2020
Merged
6 tasks
diemol added a commit that referenced this pull request Mar 19, 2020
@kzhirata @diemol
Add Japanese translation of the PRs below (#336)
13b79c0 
* Add Japanese translation of the PRs below

#327
#326

* fix link

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
@harsha509 harsha509 deleted the shared_capabilities branch March 19, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgoldberg cgoldberg cgoldberg left review comments

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harsha509 @cgoldberg @diemol